Refactor config structure #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tsunghsienlee
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Looks good to me, and I just wish we could figure this out earlier.
tsunghsienlee
approved these changes
Dec 11, 2024
hjmshi
reviewed
Dec 11, 2024
Rename `EighConfig` and add `EigenDecompositionConfig`
tsunghsienlee
approved these changes
Dec 17, 2024
|
@tsunghsienlee has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@tsunghsienlee merged this pull request in b5dd2f2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor clearly separates the configs for matrix functions and the preconditioner computation in
DistributedShampoo.Please especially focus on
matrix_functions_types.py,shampoo_types.py, and the change to the signature ofDistributedShampooindistributed_shampoo.py.