Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hydra] Improve error message in parse_overrides #3022

Merged
merged 12 commits into from
Feb 5, 2025
Merged

Conversation

wu0607
Copy link
Contributor

@wu0607 wu0607 commented Feb 5, 2025

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Motivation

(Write your motivation for proposed changes here.)

Have you read the Contributing Guidelines on pull requests?

Yes/No

Test Plan

(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2025
@wu0607 wu0607 marked this pull request as ready for review February 5, 2025 20:17
Copy link
Contributor

@jesszzzz jesszzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this error message clearer!

@jesszzzz jesszzzz merged commit 618ab4b into main Feb 5, 2025
41 checks passed
@jesszzzz jesszzzz deleted the error_propagation branch February 5, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants