Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[Bugfix] - Change assertion to just provide a user error if unused scale provided #2544

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

jturner65
Copy link
Contributor

This PR changes an assertion that no scale is provided to the vertex-semantics mesh instantiation method to instead be a user error message, and removes an assertion that no lighting key be provided, but rather hardcodes the actual creation to be NO_LIGHT_KEY. Recent changes to allow for support of stage scaling have caused datasets that instantiate vertex-semantics meshes (like Replica) to unnecessarily fire this assertion. Besides, seems a bit extreme to assert on data being provided that is not even used.

Motivation and Context

How Has This Been Tested

Locally C++ and Python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Seems extreme to have assertions occur because unused information is provided.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 12, 2025
@jturner65 jturner65 requested review from aclegg3 and 0mdc February 12, 2025 15:01
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jturner65 jturner65 merged commit 59cd255 into main Feb 12, 2025
7 checks passed
@jturner65 jturner65 deleted the Bugfix_ScaleAssertion branch February 12, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants