--[Bugfix] - Change assertion to just provide a user error if unused scale provided #2544
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes an assertion that no scale is provided to the vertex-semantics mesh instantiation method to instead be a user error message, and removes an assertion that no lighting key be provided, but rather hardcodes the actual creation to be NO_LIGHT_KEY. Recent changes to allow for support of stage scaling have caused datasets that instantiate vertex-semantics meshes (like Replica) to unnecessarily fire this assertion. Besides, seems a bit extreme to assert on data being provided that is not even used.
Motivation and Context
How Has This Been Tested
Locally C++ and Python tests pass
Types of changes
Checklist