Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing unused attribute, adding initialization of _fog_of_war_mask #1058

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naokiyokoyama
Copy link
Contributor

Motivation and Context

The attribute on line 698 (self._grid_delta) is not used at all anywhere in the repo, so it can be deleted.
On the other hand, self._fog_of_war_mask IS used a lot but is NOT in the __init__, which confuses IDEs like PyCharm when writing code for inheriting this class and trying to access/edit self._fog_of_war_mask. Thus it is added here.

How Has This Been Tested

Non-breaking changes

Types of changes

  • Docs change / refactoring / dependency upgrade

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants