removing unused attribute, adding initialization of _fog_of_war_mask #1058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The attribute on line 698 (
self._grid_delta
) is not used at all anywhere in the repo, so it can be deleted.On the other hand,
self._fog_of_war_mask
IS used a lot but is NOT in the__init__
, which confuses IDEs like PyCharm when writing code for inheriting this class and trying to access/editself._fog_of_war_mask
. Thus it is added here.How Has This Been Tested
Non-breaking changes
Types of changes
Checklist