Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

factor out autograd-dependent tests #124

Merged
merged 3 commits into from
Jul 4, 2024
Merged

factor out autograd-dependent tests #124

merged 3 commits into from
Jul 4, 2024

Conversation

mfschubert
Copy link
Collaborator

@mfschubert mfschubert commented Jul 2, 2024 •
edited
Loading

This fixes #122

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2024
@smartalecH smartalecH self-requested a review July 4, 2024 02:49
smartalecH
smartalecH approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@smartalecH smartalecH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@mfschubert mfschubert merged commit 39b44b1 into main Jul 4, 2024
5 of 6 checks passed
@mfschubert mfschubert deleted the agfix branch July 4, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartalecH smartalecH smartalecH approved these changes

Assignees

@smartalecH smartalecH

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken tests due to new numpy version
3 participants
@mfschubert @smartalecH @facebook-github-bot