Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PCF2-Lift Options to a shared location #2198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

calebzj
Copy link

@calebzj calebzj commented Mar 17, 2023

Summary: This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Differential Revision: D44062784

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Mar 17, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44062784

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request Mar 17, 2023
Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Differential Revision: D44062784

fbshipit-source-id: 98950f8f15f994a53b6a20e2ed66daecc4b7c2bc
calebzj pushed a commit to calebzj/fbpcs that referenced this pull request Mar 17, 2023
Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Differential Revision: D44062784

fbshipit-source-id: 888fbce44832fd5be3fe2e30c7d3fc60cf29f223
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44062784

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request Mar 17, 2023
Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Differential Revision: D44062784

fbshipit-source-id: 0f13d31ef882d6eb3b4908fa53a4b7eafe5d1f7c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request Mar 20, 2023
Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Reviewed By: ajinkya-ghonge, haochenuw

Differential Revision: D44062784

fbshipit-source-id: 4ed6f17f5e0200600324254e58f94904c00d0fa2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request Mar 24, 2023
Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Reviewed By: ajinkya-ghonge, haochenuw

Differential Revision: D44062784

fbshipit-source-id: 3e1779d48b003ee1ac16dc4e77e47a3c80e0f111
calebzj pushed a commit to calebzj/fbpcs that referenced this pull request Mar 27, 2023
Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Reviewed By: ajinkya-ghonge, haochenuw

Differential Revision: D44062784

fbshipit-source-id: d2ea44f9edaa045666ce5ff0095481af225b243c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44062784

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request Mar 28, 2023
Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Reviewed By: ajinkya-ghonge, haochenuw

Differential Revision: D44062784

fbshipit-source-id: 46b4dc7fc95f14d24eeed32462569f4c3ffad9fe
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44062784

calebzj pushed a commit to calebzj/fbpcs that referenced this pull request Mar 30, 2023
Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Reviewed By: ajinkya-ghonge, haochenuw

Differential Revision: D44062784

fbshipit-source-id: 2874edb15d3c5abc67630e1a2192484017866136
Summary:
Pull Request resolved: facebookresearch#2198

This is moving the Lift options out of main so that they can be used in other parts of the code. This is especially important for feature flagging within the cpp code.

Reviewed By: ajinkya-ghonge, haochenuw

Differential Revision: D44062784

fbshipit-source-id: c63c45566219ec11272ac58c2efbb7c7437d1f21
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D44062784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants