Fix Strategy class to ensure consistent tensor operations for data normalization #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@JasonKChow has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
JasonKChow
requested changes
Oct 14, 2024
JasonKChow
requested changes
Oct 15, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Summary: This PR resolves mypy linter issues in `plotting.py` by adding `None` checks for `strat.model`, providing a missing type hint for the `locs` variable, and updating `matplotlib.markers` to use a string digit instead of an integer. This was done because adding more strict type hints in other parts of the code revealed these errors, which need to be fixed before proceeding with #403 . Pull Request resolved: #405 Reviewed By: crasanders Differential Revision: D64415474 Pulled By: JasonKChow fbshipit-source-id: 1bbb3cc28d7c15b193404f2ca6407a6996d4d062
yalsaffar
force-pushed
the
strategy-normalize_inputs-fix
branch
from
01cfbb5
to
aeadbf1
Compare
|
@JasonKChow has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
JasonKChow
approved these changes
Oct 16, 2024
JasonKChow
approved these changes
Oct 16, 2024
|
@JasonKChow merged this pull request in 09b1d59. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the second part of issue #365, focusing on the
Strategyclass and how data is added and normalized, transitioning the process to use tensors instead of NumPy operations.The changes were made specifically within the
normalize_inputsmethod of theStrategyclass. Previously, this method had mismatched docstrings indicatingnp.arrayusage. Now, it consistently accepts and returns tensors, performing all operations within tensors.The
normalize_inputsmethod is called inadd_data()(where the confusion arises), as the data passed can vary (either tensors ornp.array). To resolve this, the method now acts as the first step, accepting both formats and then converting everything to tensors for consistent operations (model fitting later on). It’s also crucial to ensure the data type isfloat64, asgpytorchdoes not support other data types.Additionally, a detailed docstring was added to clarify the method's expectations and ensure its proper use going forward.