Allow parsing of nested numbers from config #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64138450 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Oct 10, 2024
Summary: Nested arrays were not directly parseable from the config. E.g., [12, [2, 4], 2, [2.0, 4]] would raise an exception. If a nested array is detected, it will check whether the desired type is either a float or an int and if so, it'll evaluate the string as a number then recursively cast. If the desired type is neither a float nor an int, it will raise a ValueException. Differential Revision: D64138450
JasonKChow
force-pushed
the
export-D64138450
branch
from
ebbf5bd
to
06dfaa7
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Oct 10, 2024
Summary: Nested arrays were not directly parseable from the config. E.g., [12, [2, 4], 2, [2.0, 4]] would raise an exception. If a nested array is detected, it will check whether the desired type is either a float or an int and if so, it'll evaluate the string as a number then recursively cast. If the desired type is neither a float nor an int, it will raise a ValueException. Differential Revision: D64138450
JasonKChow
force-pushed
the
export-D64138450
branch
from
06dfaa7
to
13de785
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64138450 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D64138450 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Oct 14, 2024
Summary: Nested arrays were not directly parseable from the config. E.g., [12, [2, 4], 2, [2.0, 4]] would raise an exception. If a nested array is detected, it will check whether the desired type is either a float or an int and if so, it'll evaluate the string as a number then recursively cast. If the desired type is neither a float nor an int, it will raise a ValueException. Differential Revision: D64138450
JasonKChow
force-pushed
the
export-D64138450
branch
from
13de785
to
d4101eb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64138450 |
JasonKChow
force-pushed
the
export-D64138450
branch
from
d4101eb
to
e561dc1
Compare
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Oct 14, 2024
Summary: Nested arrays were not directly parseable from the config. E.g., [12, [2, 4], 2, [2.0, 4]] would raise an exception. If a nested array is detected, it will check whether the desired type is either a float or an int and if so, it'll evaluate the string as a number then recursively cast. If the desired type is neither a float nor an int, it will raise a ValueException. Differential Revision: D64138450
|
This pull request was exported from Phabricator. Differential Revision: D64138450 |
JasonKChow
added a commit
to JasonKChow/aepsych
that referenced
this pull request
Oct 18, 2024
Summary: Nested arrays were not directly parseable from the config. E.g., [12, [2, 4], 2, [2.0, 4]] would raise an exception. If a nested array is detected, it will check whether the desired type is either a float or an int and if so, it'll evaluate the string as a number then recursively cast. If the desired type is neither a float nor an int, it will raise a ValueException. Reviewed By: crasanders Differential Revision: D64138450
JasonKChow
force-pushed
the
export-D64138450
branch
from
e561dc1
to
8d5d543
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64138450 |
Summary: To support more granular parameter settings in the future, we need to change the config style to be able to separately handle settings for each parameter. Currently the only setting for each parameter are the lower and upper bounds, but we also implement parameter types here (which currently does nothing). This is technically not a breaking change. Even though we have changed all documentation to match the new style, it is possible to define parameter bounds the old way. This will throw a warning however as this causes all parameter-specific bounds to be ignored. Old tests in test_config.py are also modified to match the new style unless specifically testing for these changes. Other tests not in test_config.py are left unchanged (this was the case for the previous major config change where experiment was a section). Reviewed By: crasanders Differential Revision: D63679916
Summary: Nested arrays were not directly parseable from the config. E.g., [12, [2, 4], 2, [2.0, 4]] would raise an exception. If a nested array is detected, it will check whether the desired type is either a float or an int and if so, it'll evaluate the string as a number then recursively cast. If the desired type is neither a float nor an int, it will raise a ValueException. Reviewed By: crasanders Differential Revision: D64138450
JasonKChow
force-pushed
the
export-D64138450
branch
from
8d5d543
to
2d2304b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64138450 |
|
This pull request has been merged in a74d426. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Nested arrays were not directly parseable from the config. E.g., [12, [2, 4], 2, [2.0, 4]] would raise an exception.
If a nested array is detected, it will check whether the desired type is either a float or an int and if so, it'll evaluate the string as a number then recursively cast.
If the desired type is neither a float nor an int, it will raise a ValueException.
Differential Revision: D64138450