various speed ups #319
Closed
various speed ups #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49388668 |
crasanders
pushed a commit
to crasanders/aepsych
that referenced
this pull request
Sep 20, 2023
Summary: Made AEPsych faster in the following ways: - Now takes advantage of optimize_acqf's timeout_sec argument to more reliably limit the amount of time spent optimizing the acqf using the max_gen_time option in configs. - Changes the optimization algorithm for inverse model querying to use botorch's optimize_acqf, which should be faster and more accurate than scipy.minimize. - "max_time" can be sent in query messages to limit the amount of time, in seconds, the model will spend searching for the queried value (using the aforementioned timeout_sec arg). A query method was added to the python client to test these new features. Differential Revision: D49388668
crasanders
force-pushed
the
export-D49388668
branch
from
88498ee
to
53b88b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49388668 |
crasanders
pushed a commit
to crasanders/aepsych
that referenced
this pull request
Sep 21, 2023
Summary: Made AEPsych faster in the following ways: - Now takes advantage of optimize_acqf's timeout_sec argument to more reliably limit the amount of time spent optimizing the acqf using the max_gen_time option in configs. - Changes the optimization algorithm for inverse model querying to use botorch's optimize_acqf, which should be faster and more accurate than scipy.minimize. - "max_time" can be sent in query messages to limit the amount of time, in seconds, the model will spend searching for the queried value (using the aforementioned timeout_sec arg). A query method was added to the python client to test these new features. Differential Revision: D49388668
crasanders
force-pushed
the
export-D49388668
branch
from
53b88b9
to
8baf5c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49388668 |
crasanders
pushed a commit
to crasanders/aepsych
that referenced
this pull request
Oct 16, 2023
Summary: Made AEPsych faster in the following ways: - Now takes advantage of optimize_acqf's timeout_sec argument to more reliably limit the amount of time spent optimizing the acqf using the max_gen_time option in configs. - Changes the optimization algorithm for inverse model querying to use botorch's optimize_acqf, which should be faster and more accurate than scipy.minimize. - "max_time" can be sent in query messages to limit the amount of time, in seconds, the model will spend searching for the queried value (using the aforementioned timeout_sec arg). A query method was added to the python client to test these new features. Reviewed By: strykerb Differential Revision: D49388668
crasanders
force-pushed
the
export-D49388668
branch
from
8baf5c1
to
6077299
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49388668 |
crasanders
pushed a commit
to crasanders/aepsych
that referenced
this pull request
Oct 16, 2023
Summary: Made AEPsych faster in the following ways: - Now takes advantage of optimize_acqf's timeout_sec argument to more reliably limit the amount of time spent optimizing the acqf using the max_gen_time option in configs. - Changes the optimization algorithm for inverse model querying to use botorch's optimize_acqf, which should be faster and more accurate than scipy.minimize. - "max_time" can be sent in query messages to limit the amount of time, in seconds, the model will spend searching for the queried value (using the aforementioned timeout_sec arg). A query method was added to the python client to test these new features. Reviewed By: strykerb Differential Revision: D49388668
crasanders
force-pushed
the
export-D49388668
branch
from
6077299
to
4c42740
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49388668 |
Summary: Made AEPsych faster in the following ways: - Now takes advantage of optimize_acqf's timeout_sec argument to more reliably limit the amount of time spent optimizing the acqf using the max_gen_time option in configs. - Changes the optimization algorithm for inverse model querying to use botorch's optimize_acqf, which should be faster and more accurate than scipy.minimize. - "max_time" can be sent in query messages to limit the amount of time, in seconds, the model will spend searching for the queried value (using the aforementioned timeout_sec arg). A query method was added to the python client to test these new features. Reviewed By: strykerb Differential Revision: D49388668
crasanders
pushed a commit
to crasanders/aepsych
that referenced
this pull request
Oct 16, 2023
Summary: Made AEPsych faster in the following ways: - Now takes advantage of optimize_acqf's timeout_sec argument to more reliably limit the amount of time spent optimizing the acqf using the max_gen_time option in configs. - Changes the optimization algorithm for inverse model querying to use botorch's optimize_acqf, which should be faster and more accurate than scipy.minimize. - "max_time" can be sent in query messages to limit the amount of time, in seconds, the model will spend searching for the queried value (using the aforementioned timeout_sec arg). A query method was added to the python client to test these new features. Reviewed By: strykerb Differential Revision: D49388668
crasanders
force-pushed
the
export-D49388668
branch
from
4c42740
to
432eade
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49388668 |
crasanders
force-pushed
the
export-D49388668
branch
from
432eade
to
4a19c0d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49388668 |
|
This pull request has been merged in 1c083e8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Made AEPsych faster in the following ways:
Now takes advantage of optimize_acqf's timeout_sec argument to more reliably limit the amount of time spent optimizing the acqf using the max_gen_time option in configs.
Changes the optimization algorithm for inverse model querying to use botorch's optimize_acqf, which should be faster and more accurate than scipy.minimize.
"max_time" can be sent in query messages to limit the amount of time, in seconds, the model will spend searching for the queried value (using the aforementioned timeout_sec arg).
A query method was added to the python client to test these new features.
Differential Revision: D49388668