add seed to Ax client; temporarily skipping flaky test #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48123177 |
crasanders
added a commit
to crasanders/aepsych
that referenced
this pull request
Aug 8, 2023
…rch#312) Summary: Pull Request resolved: facebookresearch#312 Adding the ability to specify a seed for the ax client within the config for deterministic experiments. It turns out there is still some non-determinism on the AEPsych side, though, after the experiment is over. Skipping a test that is flaky due to this until it is fixed. Reviewed By: mpolson64 Differential Revision: D48123177 fbshipit-source-id: 1eb8fded98271dc3d007c459173eb0116febdcd1
crasanders
force-pushed
the
export-D48123177
branch
from
95dfa0c
to
706556b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48123177 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D48123177 |
|
This pull request was exported from Phabricator. Differential Revision: D48123177 |
crasanders
added a commit
to crasanders/aepsych
that referenced
this pull request
Aug 11, 2023
…rch#312) Summary: Pull Request resolved: facebookresearch#312 Adding the ability to specify a seed for the ax client within the config for deterministic experiments. It turns out there is still some non-determinism on the AEPsych side, though, after the experiment is over. Skipping a test that is flaky due to this until it is fixed. Reviewed By: mpolson64 Differential Revision: D48123177 fbshipit-source-id: 717b30be59bccf995fa413af30b03ef33a558fb2
crasanders
force-pushed
the
export-D48123177
branch
from
706556b
to
c9eabf3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48123177 |
crasanders
added a commit
to crasanders/aepsych
that referenced
this pull request
Aug 15, 2023
…rch#312) Summary: Pull Request resolved: facebookresearch#312 Adding the ability to specify a seed for the ax client within the config for deterministic experiments. It turns out there is still some non-determinism on the AEPsych side, though, after the experiment is over. Skipping a test that is flaky due to this until it is fixed. Reviewed By: mpolson64 Differential Revision: D48123177 fbshipit-source-id: aa90d17f1611009a013c2ae978e1b07891b5527e
crasanders
force-pushed
the
export-D48123177
branch
from
c9eabf3
to
5a6d521
Compare
…rch#312) Summary: Pull Request resolved: facebookresearch#312 Adding the ability to specify a seed for the ax client within the config for deterministic experiments. It turns out there is still some non-determinism on the AEPsych side, though, after the experiment is over. Skipping a test that is flaky due to this until it is fixed. Reviewed By: mpolson64 Differential Revision: D48123177 fbshipit-source-id: da48721fbbecdcc68dc9266922d4ba0052e38e90
|
This pull request was exported from Phabricator. Differential Revision: D48123177 |
crasanders
force-pushed
the
export-D48123177
branch
from
5a6d521
to
0332612
Compare
|
This pull request has been merged in 10834d9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adding the ability to specify a seed for the ax client within the config for deterministic experiments. It turns out there is still some non-determinism on the AEPsych side, though, after the experiment is over. Skipping a test that is flaky due to this until it is fixed.
Differential Revision: D48123177