remove unnecessary sockets #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47733703 |
crasanders
added a commit
to crasanders/aepsych
that referenced
this pull request
Jul 25, 2023
Summary: Pull Request resolved: facebookresearch#306 Removing ZMQ socket because it is no longer necesssary (all clients can communicate over pysocket), and the pyzmq dependency is a burden. Differential Revision: D47733703 fbshipit-source-id: 18bee0d1537cb3638d92b2cc14bb145ec4e15bbc
crasanders
force-pushed
the
export-D47733703
branch
from
7975c22
to
93f1a54
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47733703 |
crasanders
added a commit
to crasanders/aepsych
that referenced
this pull request
Jul 25, 2023
Summary: Pull Request resolved: facebookresearch#306 Removing ZMQ socket because it is no longer necesssary (all clients can communicate over pysocket), and the pyzmq dependency is a burden. Differential Revision: D47733703 fbshipit-source-id: 379a3f686626b415b087d19701f5b8e1ad5971ac
crasanders
force-pushed
the
export-D47733703
branch
from
93f1a54
to
7caeff8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47733703 |
crasanders
added a commit
to crasanders/aepsych
that referenced
this pull request
Jul 25, 2023
Summary: Pull Request resolved: facebookresearch#306 Removing ZMQ socket because it is no longer necesssary (all clients can communicate over pysocket), and the pyzmq dependency is a burden. Differential Revision: D47733703 fbshipit-source-id: 17355d35a6e73ab7a53f5f9ce207c4b1014cecb0
crasanders
force-pushed
the
export-D47733703
branch
from
7caeff8
to
366ae68
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47733703 |
Summary: Pull Request resolved: facebookresearch#306 Removing ZMQ socket because it is no longer necesssary (all clients can communicate over pysocket), and the pyzmq dependency is a burden. Reviewed By: mshvartsman Differential Revision: D47733703 fbshipit-source-id: 0fa9a8de6e548321c23bf2db83af9eef49d59fca
crasanders
force-pushed
the
export-D47733703
branch
from
366ae68
to
ec50641
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47733703 |
|
This pull request has been merged in 32b0bb5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Removing ZMQ socket because it is no longer necesssary (all clients can communicate over pysocket), and the pyzmq dependency is a burden.
Differential Revision: D47733703