Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove usage of MinimumTrialsInStatus in AEPsych (#326)
Summary: Pull Request resolved: #326 X-link: facebook/Ax#2134 We have replaced the more limited MinimumTrialsInStatus with the more flexible TransitionCriterion `MinTrials`. This diff is the first in a set of diffs intended to update the legacy usage of CompletionCriterion in AEPsych. In following diffs we will: - Completely remove the completion criterion file - update all four completion criterion defined in aepsych code here: https://www.internalfb.com/code/fbsource/[409e3dfb01ec5c613d34e58c491d63e8051d10d9]/fbcode/frl/ae/aepsych/tests/generators/test_completion_criteria.py?lines=12-15 - revisit storage - remove all todos in gennode, genstrat, and transitioncriterion classes related to maintaining this deprecated code - update AEPsych GSs as needed - determine if run indefinetly can be replaced by simply having gen_unlimited_trials = true Additional info: https://docs.google.com/document/d/1JWaD20ux8dRVWom3VhTBkh4_1v170XNJ3Xf7EdWsMc8/edit?usp=sharing Reviewed By: crasanders Differential Revision: D52848140 fbshipit-source-id: cfbc96052f3898e4b3466d76f9cb11b18452fd9a
- Loading branch information