Skip to content

Commit

Permalink
Increase workflow os/python version test coverage (#388)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #388

Added different windows and macos-13 to the os's test matrix in build-lint-test workflow. Also added python 3.11, creating a 3x3 matrix.

macos-13 is important to ensure compatability with intel macs, macos-latest will cover M1 Macs.

Currently hangs on testing on windows (all version of Python) but this is a failed test that should have been caught all along.

Reviewed By: crasanders

Differential Revision: D63403529

fbshipit-source-id: e6f2e2eb211b41abc784436c02676ae302b9a4a6
  • Loading branch information
JasonKChow authored and facebook-github-bot committed Sep 26, 2024
1 parent d975192 commit 4ad541d
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/build-lint-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,12 @@ jobs:
build-test:

runs-on: macos-latest
strategy:
fail-fast: false
matrix:
python-version: ["3.10", "3.12"]
python-version: ["3.10", "3.11", "3.12"]
os: [macos-latest, windows-latest, macos-13]
runs-on: ${{ matrix.os }}

steps:
- uses: actions/checkout@v2
Expand Down

0 comments on commit 4ad541d

Please sign in to comment.