Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix UserWarning for floor division in position encoder #159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jveitchmichaelis
Copy link

@jveitchmichaelis jveitchmichaelis commented Nov 10, 2022

Torch currently throws a UserWarning for a division op in the position encoding module.

UserWarning: __floordiv__ is deprecated, and its behavior will change in a future version of pytorch. It currently rounds toward 0 (like the 'trunc' function NOT 'floor'). 
This results in incorrect rounding for negative values. To keep the current behavior, use torch.div(a, b, rounding_mode='trunc'), or for actual floor division, use torch.div(a, b, rounding_mode='floor')

Using the trunc rounding mode retains current behaviour, but presumably floor would also be fine here as dim_t should never be negative.

EDIT: (There may be more places that I haven't triggered...!)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 10, 2022
@jveitchmichaelis jveitchmichaelis changed the title fix userwarning for rounded division in position encoder fix UserWarning for rounded division in position encoder Nov 10, 2022
@jveitchmichaelis jveitchmichaelis changed the title fix UserWarning for rounded division in position encoder fix UserWarning for floor division in position encoder Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants