Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[et] Update execution trace dep to support new format #72

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

briancoutinho
Copy link
Contributor

@briancoutinho briancoutinho commented Oct 13, 2023

What does this PR do?

Updates to new Chakra schema carried forward in Param repo

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you update the changelog?
    • N/A

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (66e3c54) 0.00% compared to head (49d0102) 91.06%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main      #72       +/-   ##
=========================================
+ Coverage      0   91.06%   +91.06%     
=========================================
  Files         0       30       +30     
  Lines         0     2562     +2562     
=========================================
+ Hits          0     2333     +2333     
- Misses        0      229      +229     
Files Coverage Δ
tests/test_execution_trace.py 100.00% <100.00%> (ø)

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@briancoutinho briancoutinho changed the title [et] Update execuion trace dep to support new format [et] Update execution trace dep to support new format Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants