Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Fix errors caused by out of sync with timm #122

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xuao575
Copy link

@xuao575 xuao575 commented Sep 8, 2022

  1. Fix the module not found error. The timm removed Novograd a long time ago (18 Aug 2021) and replaced it with Nvnovograd, which is already presented in the code.

huggingface/pytorch-image-models@ac469b5#:~:text=Remove%20novograd.py%20impl%20as%20it%20was%20messy%2C%20keep%20nvnovograd

  1. Fix TypeError: init() got an unexpected keyword argument 'pretrained_cfg'. After the func create_model in main.py is called, the func create_fn of timm provides a parameter pretrained_cfg, which is needed in each model create method.

https://github.com/rwightman/pytorch-image-models/blob/master/timm/models/factory.py#:~:text=model%20%3D%20create_fn(pretrained%3Dpretrained%2C%20pretrained_cfg%3Dpretrained_cfg%2C%20**kwargs)

@facebook-github-bot
Copy link

Hi @aoxu2000!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@xuao575 xuao575 changed the title Fix errors caused by out of time with timm Fix errors caused by out of sync with timm Sep 8, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 8, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants