Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] CNN #74

Merged
merged 26 commits into from
Apr 7, 2024
Merged

[Model] CNN #74

merged 26 commits into from
Apr 7, 2024

Conversation

matteobettini
Copy link
Collaborator

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 93.89313% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 53.27%. Comparing base (e6afcf5) to head (138bcf0).

Files Patch % Lines
benchmarl/models/cnn.py 91.86% 7 Missing ⚠️
test/test_models.py 97.61% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #74       +/-   ##
===========================================
- Coverage   89.99%   53.27%   -36.72%     
===========================================
  Files          69       70        +1     
  Lines        2739     2866      +127     
===========================================
- Hits         2465     1527      -938     
- Misses        274     1339     +1065     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matteobettini matteobettini marked this pull request as ready for review April 5, 2024 16:50
@matteobettini matteobettini merged commit e272278 into main Apr 7, 2024
13 checks passed
@matteobettini matteobettini deleted the Founding-Zero-main branch April 7, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants