Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add presto function 'from_base32' #7672

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Add presto function 'from_base32' #7672

wants to merge 9 commits into from

Conversation

Joe-Abraham
Copy link
Contributor

@Joe-Abraham Joe-Abraham commented Nov 21, 2023 •
edited
Loading

Add presto function 'from_base32'

@netlify Netlify
Copy link

netlify bot commented Nov 21, 2023 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 123e464
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6700eb31501a57000809a3fb

@facebook-github-bot
Copy link
Contributor

Hi @Joe-Abraham!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Joe-Abraham Joe-Abraham marked this pull request as draft November 21, 2023 08:36
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2023
@Joe-Abraham Joe-Abraham changed the title Add scalar function 'to_base32' and 'from_base32' Add scalar function 'to_base32' and 'from_base32' to presto Nov 21, 2023
@Joe-Abraham Joe-Abraham changed the title Add scalar function 'to_base32' and 'from_base32' to presto Add presto function 'to_base32' and 'from_base32' Nov 21, 2023
@Joe-Abraham Joe-Abraham changed the title Add presto function 'to_base32' and 'from_base32' [WIP]Add presto function 'to_base32' and 'from_base32' Nov 21, 2023
@Joe-Abraham Joe-Abraham changed the title [WIP]Add presto function 'to_base32' and 'from_base32' [WIP] Add presto function 'to_base32' and 'from_base32' Nov 21, 2023
@Joe-Abraham Joe-Abraham changed the title [WIP] Add presto function 'to_base32' and 'from_base32' Add presto function 'to_base32' and 'from_base32' Nov 22, 2023
@Joe-Abraham
Copy link
Contributor Author

@aditi-pandit Can you please review?

@Joe-Abraham Joe-Abraham marked this pull request as ready for review November 22, 2023 06:48
@Joe-Abraham Joe-Abraham force-pushed the base32 branch 7 times, most recently from 5c0d79d to 59797b0 Compare May 8, 2024 08:15
@Joe-Abraham Joe-Abraham mentioned this pull request Jul 3, 2024
Open
czentgr
czentgr reviewed Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the new function.

velox/functions/prestosql/registration/BinaryFunctionsRegistration.cpp Show resolved Hide resolved
czentgr
czentgr approved these changes Jul 9, 2024
View reviewed changes
velox/common/encode/Base32.h Outdated Show resolved Hide resolved
@Joe-Abraham Joe-Abraham mentioned this pull request Jul 12, 2024
Closed
@Joe-Abraham Joe-Abraham force-pushed the base32 branch 3 times, most recently from 357cb54 to cb3719a Compare August 8, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodsatya pramodsatya pramodsatya left review comments

@karteekmurthys karteekmurthys karteekmurthys approved these changes

@czentgr czentgr czentgr approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add from_base32 Presto function
6 participants
@Joe-Abraham @facebook-github-bot @aditi-pandit @czentgr @karteekmurthys @pramodsatya