fix(parquet): Support converted type in timestamp reader #11964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
approved these changes
Dec 27, 2024
Yuhta
added
the
ready-to-merge
|
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thank you for helping review and merge this PR! |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
…ubator#11964) Summary: Gluten observed a UT failure at the code location below. The cause is that the timestamp schema element lacks a logical type and is composed of type, name, and converted_type. This PR allows parsing converted type from schema elements and uses it in the timestamp reader to determine the timestamp precision if logical type is not supplied. https://github.com/facebookincubator/velox/blob/87c558e094043c5451659c59d38ffc1bd6de781a/velox/dwio/parquet/reader/TimestampColumnReader.h#L99 Pull Request resolved: facebookincubator#11964 Reviewed By: xiaoxmeng Differential Revision: D67718622 Pulled By: pedroerp fbshipit-source-id: 948e597447e43444abb2f5f56f17a44fbd0a16ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gluten observed a UT failure at the code location below. The cause is that the
timestamp schema element lacks a logical type and is composed of type, name,
and converted_type. This PR allows parsing converted type from schema elements
and uses it in the timestamp reader to determine the timestamp precision if
logical type is not supplied.
velox/velox/dwio/parquet/reader/TimestampColumnReader.h
Line 99 in 87c558e