fix(CI): Disable mac builds on fork #11962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuan Zhou <[email protected]>
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
majetideepak
changed the title
|
Looks good to me. But will let @assignUser make a pass as well. |
assignUser
reviewed
Jan 6, 2025
|
@assignUser Hi, thanks for the explanation, I think the issue is it may generate many reports(on each commit?) especially for active developers . Here's one example: Here's the GHA use case in apache/Spark(also disabled on fork) thanks, -yuan |
assignUser
approved these changes
Jan 7, 2025
majetideepak
added
the
ready-to-merge
|
@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kevinwilfong merged this pull request in 8bbc20c. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: This patch disabled the mac build tests on fork, aligning with linux builds https://github.com/facebookincubator/velox/blob/main/.github/workflows/linux-build-base.yml#L30 Pull Request resolved: facebookincubator#11962 Reviewed By: Yuhta Differential Revision: D67910194 Pulled By: kevinwilfong fbshipit-source-id: b2b5808448d678e30b4cbfe97c5f4c08693ec9b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch disabled the mac build tests on fork, aligning with linux builds
https://github.com/facebookincubator/velox/blob/main/.github/workflows/linux-build-base.yml#L30