refactor(hive): Move WriterOptions update to file-formats #11956
+375
−600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
majetideepak
changed the title
majetideepak
changed the title
JkSelf
reviewed
Dec 26, 2024
| @@ -44,9 +44,6 @@ class HiveConfig { | |||
|
|
|||
| /// Maximum number of (bucketed) partitions per a single table writer | |||
| /// instance. | |||
| /// | |||
| /// TODO: remove hive_orc_use_column_names since it doesn't exist in presto, | |||
| /// right now this is only used for testing. | |||
| static constexpr const char* kMaxPartitionsPerWriters = | |||
There was a problem hiding this comment.
@majetideepak How about moving the following file format-related configurations in HiveConfig into the file format's configuration file as well?
https://github.com/facebookincubator/velox/blob/main/velox/connectors/hive/HiveConfig.h#L76-L84
There was a problem hiding this comment.
@JkSelf I prefer to handle the ReaderOptions in a separate PR. The ReaderOptions are not specialized per file format similar to the WriterOptions
majetideepak
force-pushed
the
fix-writeroptions
branch
from
85eaa5f to
269a98f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WriterOptions of the file format should implement how to process
format-specific session and connector configs.
This will decouple the Hive Connector library from the file-format libraries.
This was previously changed here #10915