feat: Support decimal type for Spark in function

velox/docs/functions/spark/array.rst

@@ -196,7 +196,7 @@ Array Functions
 .. spark:function:: in(value, array(E)) -> boolean
 
     Returns true if value matches at least one of the elements of the array.
-    Supports BOOLEAN, REAL, DOUBLE, BIGINT, VARCHAR, TIMESTAMP, DATE input types.
+    Supports BOOLEAN, REAL, DOUBLE, BIGINT, VARCHAR, TIMESTAMP, DATE, DECIMAL input types.
 
 .. spark:function:: shuffle(array(E), seed) -> array(E)
 

velox/docs/functions/spark/decimal.rst

@@ -115,6 +115,10 @@ Returns NULL when the actual result cannot be represented with the calculated de
 Decimal Functions
 -----------------
 
+.. spark:function:: in(x: decimal(p, s), array(decimal(p, s))) -> boolean
+
+    Returns true if ``x`` matches at least one of the elements of the array.
+
 .. spark:function:: unaryminus(x: decimal(p, s)) -> r: decimal(p, s)
 
     Returns negated value of x (r = -x). Corresponds to Spark's operator ``-``.

velox/functions/sparksql/In.cpp

@@ -143,6 +143,8 @@ void registerIn(const std::string& prefix) {
   registerInFn<Varchar>(prefix);
   registerInFn<Timestamp>(prefix);
   registerInFn<Date>(prefix);
+  registerInFn<ShortDecimal<P1, S1>>(prefix);
+  registerInFn<LongDecimal<P1, S1>>(prefix);
 }
 
 } // namespace facebook::velox::functions::sparksql

velox/functions/sparksql/tests/InTest.cpp

@@ -194,6 +194,42 @@ TEST_F(InTest, Bool) {
   EXPECT_EQ(in<bool>(false, {false}), true);
 }
 
+TEST_F(InTest, shortDecimal) {
+  EXPECT_EQ(in<int64_t>(1, {1, 2}, DECIMAL(2, 1)), true);
+  EXPECT_EQ(in<int64_t>(2, {1, 2}, DECIMAL(10, 5)), true);
+  EXPECT_EQ(in<int64_t>(3, {1, 2}, DECIMAL(17, 11)), false);
+  EXPECT_EQ(
+      in<int64_t>(
+          DecimalUtil::kShortDecimalMin,
+          {DecimalUtil::kShortDecimalMin, DecimalUtil::kShortDecimalMax},
+          DECIMAL(18, 9)),
+      true);
+  EXPECT_EQ(
+      in<int64_t>(
+          DecimalUtil::kShortDecimalMax,
+          {DecimalUtil::kShortDecimalMin, DecimalUtil::kShortDecimalMax},
+          DECIMAL(18, 9)),
+      true);
+}
+
+TEST_F(InTest, longDecimal) {
+  EXPECT_EQ(in<int128_t>(1, {1, 2}, DECIMAL(21, 2)), true);
+  EXPECT_EQ(in<int128_t>(2, {1, 2}, DECIMAL(29, 10)), true);
+  EXPECT_EQ(in<int128_t>(3, {1, 2}, DECIMAL(35, 20)), false);
+  EXPECT_EQ(
+      in<int128_t>(
+          DecimalUtil::kLongDecimalMin,
+          {DecimalUtil::kLongDecimalMin, DecimalUtil::kLongDecimalMax},
+          DECIMAL(38, 19)),
+      true);
+  EXPECT_EQ(
+      in<int128_t>(
+          DecimalUtil::kLongDecimalMax,
+          {DecimalUtil::kLongDecimalMin, DecimalUtil::kLongDecimalMax},
+          DECIMAL(38, 19)),
+      true);
+}
+
 TEST_F(InTest, Const) {
   const auto eval = [&](const std::string& expr) {
     return evaluateOnce<bool, bool>(expr, false);