feat: Add json_array_length Spark function #11946
Open
+106
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WangGuangxin
force-pushed
the
feat_json_array_length
branch
from
a971121 to
a5c0d3b
Compare
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
✅ Deploy Preview for meta-velox canceled.
|
WangGuangxin
requested review from
assignUser and
majetideepak
as code owners
PHILO-HE
reviewed
Dec 24, 2024
| struct JsonArrayLengthFunction { | ||
| VELOX_DEFINE_FUNCTION_TYPES(T); | ||
|
|
||
| FOLLY_ALWAYS_INLINE bool call(int32_t& len, const arg_type<Json>& json) { |
There was a problem hiding this comment.
Suggestion:
Change const arg_type<Json>& to const arg_type<Varchar>& and remove the above corresponding header.
I think JsonType is just for presto.
rui-mo
reviewed
Dec 24, 2024
| @@ -24,6 +25,8 @@ void registerJsonFunctions(const std::string& prefix) { | |||
| {prefix + "get_json_object"}); | |||
| registerFunction<JsonObjectKeysFunction, Array<Varchar>, Varchar>( | |||
| {prefix + "json_object_keys"}); | |||
| registerFunction<JsonArrayLengthFunction, int32_t, Varchar>( | |||
| {prefix + "json_array_length"}); | |||
There was a problem hiding this comment.
To avoid duplicating code, we would recommend extracting the implementation to the 'velox/functions/lib/' and registering it with corresponding return types for Presto and Spark if the semantics are the same (corner cases may need to be verified).
There was a problem hiding this comment.
@rui-mo The input type is a bit different, one is Json, another is Varchar.
There was a problem hiding this comment.
@rui-mo removed duplicated code. Please take a look again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json_array_lengthin Spark is similar as Presto but has difference in return type, Presto is int64_t, Spark is int32_t.Examples:
Spark doc: https://spark.apache.org/docs/latest/api/sql/#json_array_length