Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace setuptools/setup.py with PEP621 metadata and flit #14

Closed
wants to merge 1 commit into from
Closed

Replace setuptools/setup.py with PEP621 metadata and flit #14

wants to merge 1 commit into from

Conversation

amyreese
Copy link
Contributor

@amyreese amyreese commented Nov 30, 2023 •
edited
Loading

  • Replace setuptools/setup.py with PEP621 metadata and flit
  • Test on macos

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 30, 2023
@amyreese amyreese force-pushed the flit branch 3 times, most recently from b912d2d to 9a802df Compare November 30, 2023 00:36
@amyreese amyreese requested a review from fried November 30, 2023 02:37
@amyreese
Copy link
Contributor Author

@fried it looks like tests for 3.11 are broken on main, but #13 is looking for 3.12 support. Is this something that you plan on investigating/fixing?

@fried
Copy link
Contributor

fried commented Nov 30, 2023

i’ll look at 3.11 fixes in the morning

@fried
Copy link
Contributor

fried commented Nov 30, 2023

@amyreese thanks for working on the build scripts for this project. I have fixed 3.11 and hopefully 3.12 in #15

@amyreese amyreese force-pushed the flit branch 2 times, most recently from e28e180 to fd65026 Compare December 1, 2023 01:05
@facebook-github-bot
Copy link
Contributor

@fried has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@fried merged this pull request in 6334071.

@fried fried mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fried fried fried approved these changes

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amyreese @fried @facebook-github-bot