Skip to content

Commit

Permalink
Bump to NDK 26
Browse files Browse the repository at this point in the history
Summary:
This bumps fbjni to NDK 26, the latest stable NDK, lining up with RN 0.74 compatibility.

Google [documents](https://developer.android.com/ndk/guides/middleware-vendors#choosing_api_levels_and_ndk_versions) the expected NDK to NDK compatibility:

> NDK versions are largely compatible with each other, but occasionally there are changes that break compatibility. If you know that all of your users are using the same version of the NDK, it's best to use the same version that they do. Otherwise, use the newest version.

Differential Revision: D50296514
  • Loading branch information
NickGerleman authored and facebook-github-bot committed Oct 14, 2023
1 parent 52a14f0 commit 90ee194
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
9 changes: 4 additions & 5 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*/

plugins {
id 'com.android.library' version '8.0.2'
id 'com.android.library' version '8.1.2'
id 'maven-publish'
id 'com.vanniktech.maven.publish' version '0.25.3'
}
Expand All @@ -26,9 +26,8 @@ repositories {
}

android {
compileSdk 33
ndkVersion '25.1.8937393'

compileSdk 34
ndkVersion '26.0.10792818'
externalNativeBuild {
cmake {
path 'CMakeLists.txt'
Expand All @@ -37,7 +36,7 @@ android {

defaultConfig {
minSdkVersion 15
targetSdkVersion 33
targetSdkVersion 34
buildConfigField "boolean", "IS_INTERNAL_BUILD", 'true'
namespace "com.facebook.fbjni"

Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.1.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-all.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists

0 comments on commit 90ee194

Please sign in to comment.