-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix user_data.email_address ==> user_data.email #46
base: main
Are you sure you want to change the base?
Conversation
perhaps to avoid breaking changes we should support both variants? e.g. |
@koconnor3, I am not convinced it is needed, as |
as a matter of fact, before the 'User-Provided Data' variable type existed in Google Tag Manager (and some even now) I have seen many clients pass JSON directly the user_data event parameter in a GA4 event and it be used thus. Google's common event data for Server GTM docs lists user_data.email_address instead of user_data.email: |
That's absolutely true, but here are few points to address. I think Google needs to sort out their docs 😄 because next to some entries in the table, there is a link to the support docs where If you try to send It is indeed, plausible that users may have defined anyhow their version of user data in the past, however, currently the user_data can be only used exclusively following the gtag protocol. It won't transmit unrecognised keys anyway. I guess, an official API of the gtag, on which the template is based on, ought to take precedence over the custom solutions. At the end, sometimes a need to adapt to the latest changes is inevitable. Lets hear from the core team of the repo ;) But in general, I think the earlier updates of the gtag and GTM, should have already forced some users to make adjustments in regard to user data, hence it is safe not to stuff the template with extra code. |
Hello...? Anyone at Meta? |
Adjusts an email key name in the user_data object according to the schema of the Google Analytics 4 user-provided data.