ait: Explicitly throw when indexing a boolean tensor for masking #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
kflu
force-pushed
the
export-D53654054
branch
from
39c7d22 to
9d01673
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53654054 |
kflu
added a commit
to kflu/AITemplate
that referenced
this pull request
Feb 14, 2024
…ebookincubator#992) Summary: Currently AIT hasn't implemented `tensor[boolean_tensor]` for masking. It fail shortly after this call, at: > 'Tensor' object has no attribute 'upper_bound' ``` > link-tree/aitemplate/utils/shape_utils.py(195)convert_IntVar_to_int() -> if var.upper_bound() == var.lower_bound(): ``` Reviewed By: frank-wei, khabinov Differential Revision: D53654054
kflu
force-pushed
the
export-D53654054
branch
from
9d01673 to
d970fac
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53654054 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D53654054 |
kflu
added a commit
to kflu/AITemplate
that referenced
this pull request
Feb 15, 2024
…ebookincubator#992) Summary: Currently AIT hasn't implemented `tensor[boolean_tensor]` for masking. It fail shortly after this call, at: > 'Tensor' object has no attribute 'upper_bound' ``` > link-tree/aitemplate/utils/shape_utils.py(195)convert_IntVar_to_int() -> if var.upper_bound() == var.lower_bound(): ``` Reviewed By: frank-wei, khabinov Differential Revision: D53654054
kflu
force-pushed
the
export-D53654054
branch
from
d970fac to
3317564
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53654054 |
…ebookincubator#992) Summary: Currently AIT hasn't implemented `tensor[boolean_tensor]` for masking. It fail shortly after this call, at: > 'Tensor' object has no attribute 'upper_bound' ``` > link-tree/aitemplate/utils/shape_utils.py(195)convert_IntVar_to_int() -> if var.upper_bound() == var.lower_bound(): ``` Reviewed By: frank-wei, khabinov Differential Revision: D53654054
|
This pull request was exported from Phabricator. Differential Revision: D53654054 |
kflu
force-pushed
the
export-D53654054
branch
from
3317564 to
b3e8400
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53654054 |
|
This pull request has been merged in a99c753. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently AIT hasn't implemented
tensor[boolean_tensor]for masking. It fail shortly after this call, at:Reviewed By: khabinov
Differential Revision: D53654054