allow binary ops where only one arg is an immutable IntVarTensor #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53240440 |
bradleyhd
added a commit
to bradleyhd/AITemplate
that referenced
this pull request
Jan 30, 2024
…ebookincubator#987) Summary: rarely, the output of a call to .size() is one of the operands in a binary op, and as such has type IntVarTensor. In this case, it is okay to forward the call to elmentwise (instead of raising an error before a call to int_elementwise(). Reviewed By: khabinov Differential Revision: D53240440
bradleyhd
force-pushed
the
export-D53240440
branch
from
9e74904 to
0d22f91
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53240440 |
bradleyhd
added a commit
to bradleyhd/AITemplate
that referenced
this pull request
Jan 31, 2024
…ebookincubator#987) Summary: rarely, the output of a call to .size() is one of the operands in a binary op, and as such has type IntVarTensor. In this case, it is okay to forward the call to elmentwise (instead of raising an error before a call to int_elementwise(). Reviewed By: khabinov Differential Revision: D53240440
bradleyhd
force-pushed
the
export-D53240440
branch
from
0d22f91 to
9a1213a
Compare
…ebookincubator#987) Summary: rarely, the output of a call to .size() is one of the operands in a binary op, and as such has type IntVarTensor. In this case, it is okay to forward the call to elmentwise (instead of raising an error before a call to int_elementwise(). Reviewed By: khabinov Differential Revision: D53240440
|
This pull request was exported from Phabricator. Differential Revision: D53240440 |
bradleyhd
force-pushed
the
export-D53240440
branch
from
9a1213a to
e919f56
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53240440 |
|
This pull request has been merged in 4b27253. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: rarely, the output of a call to .size() is one of the operands in a binary op, and as such has type IntVarTensor. In this case, it is okay to forward the call to elmentwise (instead of raising an error before a call to int_elementwise().
Differential Revision: D53240440