-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for permute call with tuple args #986
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Jan 30, 2024
This pull request was exported from Phabricator. Differential Revision: D53236434 |
khabinov
approved these changes
Jan 30, 2024
bradleyhd
added a commit
to bradleyhd/AITemplate
that referenced
this pull request
Jan 30, 2024
Summary: PyTorch allows permute ops to be called on tensors with tuple args, e.g. `tensor.permute((1, 0, 2))`. this diff adds support for unwrapping the nested tuple/list. Reviewed By: khabinov Differential Revision: D53236434
bradleyhd
force-pushed
the
export-D53236434
branch
from
January 30, 2024 21:32
d65bbf7
to
a9b9abf
Compare
This pull request was exported from Phabricator. Differential Revision: D53236434 |
…ncubator#985) Summary: for mixed elementwise ops, allow bools to be cast to common dtype. this behavior mimics the behavior of PyTorch when doing things like multiplying a float16 tensor by a bool tensor (results in a float16 tensor). Reviewed By: khabinov Differential Revision: D52770344
Summary: PyTorch allows permute ops to be called on tensors with tuple args, e.g. `tensor.permute((1, 0, 2))`. this diff adds support for unwrapping the nested tuple/list. Reviewed By: khabinov Differential Revision: D53236434
bradleyhd
force-pushed
the
export-D53236434
branch
from
January 30, 2024 21:33
a9b9abf
to
5ee2e16
Compare
This pull request was exported from Phabricator. Differential Revision: D53236434 |
bradleyhd
added a commit
to bradleyhd/AITemplate
that referenced
this pull request
Jan 30, 2024
Summary: PyTorch allows permute ops to be called on tensors with tuple args, e.g. `tensor.permute((1, 0, 2))`. this diff adds support for unwrapping the nested tuple/list. Reviewed By: khabinov Differential Revision: D53236434
bradleyhd
added a commit
to bradleyhd/AITemplate
that referenced
this pull request
Jan 30, 2024
Summary: PyTorch allows permute ops to be called on tensors with tuple args, e.g. `tensor.permute((1, 0, 2))`. this diff adds support for unwrapping the nested tuple/list. Reviewed By: khabinov Differential Revision: D53236434
This pull request has been merged in cc9703a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: PyTorch allows permute ops to be called on tensors with tuple args, e.g.
tensor.permute((1, 0, 2))
. this diff adds support for unwrapping the nested tuple/list.Differential Revision: D53236434