Fix an consumer release placement issue #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
manman-ren
reviewed
Jan 9, 2025
| while (!transUsers.empty()) { | ||
| auto transUser = transUsers.pop_back_val(); | ||
| visited.insert(transUser); | ||
| if (isa<TransOp>(transUser)) { |
There was a problem hiding this comment.
Is TransOp the only op that we need to go across?
There was a problem hiding this comment.
Good question but I'm not quite sure. Basically we should consider all ops that do not really load the data from SMEM, instead, only manipulate the pointers.
htyu
force-pushed
the
hoy/consumerelease
branch
from
c8d98aa to
faeaefc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a
tt.transpreceding att.dot, the real consumer of the producer buffer should be the dot op instead of the trans op, since the trans op only recalculates the shared memory address for the dot and itself doesn't really consume the data.