Add 'panel shown' perf metrics #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdmondChuiHW
force-pushed
the
panel-perf-metrics
branch
2 times, most recently
from
6d0e7f4
to
658214e
Compare
EdmondChuiHW
force-pushed
the
panel-perf-metrics
branch
from
658214e
to
c9abf48
Compare
huntie
approved these changes
Oct 11, 2024
front_end/core/host/RNPerfMetrics.ts
Outdated
| } | ||
|
|
||
| panelShownInLocation(panelName: string, location: PanelLocation): void { | ||
| // The current panel name would be sent along via #decorateEvent(…) |
There was a problem hiding this comment.
nit
Suggested change
| // The current panel name would be sent along via #decorateEvent(…) | |
| // The current panel name will be sent along via #decorateEvent(…) |
EdmondChuiHW
force-pushed
the
panel-perf-metrics
branch
from
c9abf48
to
c359b37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Test E2E in D60692046
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.