Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup[ReactDevToolsBindingsModel]: remove no longer required setTimeout #132

Merged
merged 1 commit into from
Oct 22, 2024
Merged

cleanup[ReactDevToolsBindingsModel]: remove no longer required setTimeout #132

merged 1 commit into from
Oct 22, 2024

Conversation

hoxyq
Copy link

@hoxyq hoxyq commented Oct 22, 2024

Summary

Reverts #113. No longer required after D64552372.

Test plan

Highlighting and inspecting an element works.

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@hoxyq hoxyq merged commit ff343d8 into main Oct 22, 2024
3 checks passed
@hoxyq hoxyq deleted the react-devtools/remove-set-timeout branch October 22, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzaidman vzaidman vzaidman approved these changes

@EdmondChuiHW EdmondChuiHW Awaiting requested review from EdmondChuiHW

@huntie huntie Awaiting requested review from huntie

@robhogan robhogan Awaiting requested review from robhogan

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoxyq @vzaidman @facebook-github-bot