Update the messaging for the 'disconnected' dialog #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdmondChuiHW
commented
Sep 22, 2024
Comment on lines
+30
to
+47
| /** | ||
| * @description Text in a dialog box to explain `DevTools` can still be used while disconnected. | ||
| */ | ||
| perserveState: 'Dismiss this dialog and continue using `DevTools` while disconnected.', | ||
| /** | ||
| * @description Text on a button to dismiss the dialog | ||
| */ | ||
| closeDialog: 'Dismiss dialog', | ||
| /** | ||
| * @description Text on a button to reconnect Devtools when remote debugging terminated. | ||
| * "Remote debugging" here means that DevTools on a PC is inspecting a website running on an actual mobile device | ||
| * (see https://developer.chrome.com/docs/devtools/remote-debugging/). | ||
| */ | ||
| reconnectDevtools: 'Reconnect `DevTools`', | ||
| /** | ||
| * @description Text in a dialog box to prompt for feedback if the disconnection is unexpected. | ||
| */ | ||
| sendFeedbackMessage: '[FB-only] Please send feedback if this disconnection is unexpected.', |
There was a problem hiding this comment.
Welcome any alternatives that's more concise!
huntie
approved these changes
Sep 23, 2024
| /** | ||
| * @description Text in a dialog box to explain `DevTools` can still be used while disconnected. | ||
| */ | ||
| perserveState: 'Dismiss this dialog and continue using `DevTools` while disconnected.', |
There was a problem hiding this comment.
Unnecessary backticks around "DevTools"
There was a problem hiding this comment.
CDT has those in some existing strings. I suppose it gets swapped for something else if some build flags are specified? Let's do a pass on all of those and see if they fit our needs.
| @@ -27,12 +27,24 @@ const UIStrings = { | |||
| * device back in a state where it can be inspected, before DevTools can reconnect to it. | |||
| */ | |||
| reconnectWhenReadyByReopening: 'Reconnect when ready by reopening DevTools.', | |||
There was a problem hiding this comment.
I think we can also make this slightly more clear.
Suggested change
| reconnectWhenReadyByReopening: 'Reconnect when ready by reopening DevTools.', | |
| reconnectWhenReadyByReopening: 'Reconnect when ready (will reload DevTools).', |
EdmondChuiHW
force-pushed
the
perserve-logs-when-disconnected
branch
from
d1d0e80
to
37fb633
Compare
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Quality of life improvement (no semantic changes in this PR).
Existing
Existing dialog can be dismissed by pressing the icon button.
Doing so will allow users to navigate around the DevTools while disconnected.
Existing logs can be viewed, even though most features will stop working/appear flaky.
This has been addressed separately by highlighting the disconnected state in the UI #85:
Problem
From our internal dogfooding, requests have been raised for the ability to preserve and view logs after disconnection.
This is already supported as discussed above, so it appears to be a discovery problem.
Note: this is a separate issue from some apps' logs being cleared from CDT upon disconnection.
Test plan
In this PR
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.