Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[ReactDevToolsViewBase]: observe model from constructor #112

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

hoxyq
Copy link

@hoxyq hoxyq commented Sep 5, 2024

Summary

Stacked on #111. See this commit.

We can observe the model from the constructor, so that it is called only once per panel. This pattern is used across the project.

Test plan

Manually test that React DevTools panels work correctly.

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@hoxyq hoxyq merged commit c4c9edf into main Sep 9, 2024
2 checks passed
@hoxyq hoxyq deleted the react-devtools/observe-model-from-constructor branch September 9, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants