Improve UX for the lambda workflow (upload and lambda)
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
r-c-n
commented
Oct 29, 2024
r-c-n
commented
- Catch exceptional scenarios and provide error messages instead of panicking
- Enhance AWS lambda error logs
- Return errors in the lambda function as error responses to the client
Simplify the code for opening and processing the results file and handle and provide a more informative error message. Signed-off-by: Ricardo Cañuelo <[email protected]>
facebook-github-bot
added
the
CLA Signed
Catch the scenario where the server returns something that isn't a well formed json object. Signed-off-by: Ricardo Cañuelo <[email protected]>
Check the request contents provided by `resctl-bench upload` and return the error messages to the client as error responses. Signed-off-by: Ricardo Cañuelo <[email protected]>
Add an error log line to improve debugging and traceability in the AWS lambda logs. Signed-off-by: Ricardo Cañuelo <[email protected]>
Provide error messages both for lambda logs and for the client instead of panicking and showing a stack trace. Signed-off-by: Ricardo Cañuelo <[email protected]>
r-c-n
force-pushed
the
rcn-20241017-resctl-demo-fixes
branch
from
c497367
to
a861c55
Compare
htejun
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.