Skip to content

Commit

Permalink
Make folly::Optional TBv2 compliant (#490)
Browse files Browse the repository at this point in the history
Summary:

The container implementation for `folly::Optional` currently lacks TBv2 support. This change is a skilfully crafted cut-n-paste of the `std::optional` TBv2 implementation.

Reviewed By: ajor

Differential Revision: D56139280
  • Loading branch information
tyroguru authored and ajor committed Apr 15, 2024
1 parent a014cdd commit 0351815
Showing 1 changed file with 28 additions and 0 deletions.
28 changes: 28 additions & 0 deletions types/folly_optional_type.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,31 @@ void getSizeType(const %1%<T>& container, size_t& returnArg) {
}
}
"""

traversal_func = """
if (container.has_value()) {
return returnArg.template delegate<1>([&ctx, &container](auto ret) {
return OIInternal::getSizeType<Ctx>(ctx, *container, ret);
});
} else {
return returnArg.template delegate<0>(std::identity());
}
"""

[[codegen.processor]]
type = "types::st::Sum<DB, types::st::Unit<DB>, typename TypeHandler<Ctx, T0>::type>"
func = """
static constexpr auto elementField = make_field<Ctx, T0>("el");
auto sum = std::get<ParsedData::Sum>(d.val);
el.container_stats = result::Element::ContainerStats {
.capacity = 1,
.length = sum.index,
};
if (sum.index == 1) {
el.exclusive_size -= sizeof(T0);
stack_ins(elementField);
}
"""

0 comments on commit 0351815

Please sign in to comment.