Skip to content

Commit

Permalink
Add fbcode_builder manifests for mcrouter and ragel
Browse files Browse the repository at this point in the history
Summary:
X-link: facebookincubator/zstrong#944

https://github.com/facebook/mcrouter currently uses a legacy autotools-based build system, which forces third parties to rely on a collection of scripts hosted in the repository to build it with all required dependencies. This is brittle and has lead to many issue reports about build problems.

In facebook/mcrouter#449, I've prepared a working CMake-based build system for mcrouter that could replace the legacy autotools setup. This patch adds the necessary manifests for mcrouter and its ragel dependency so that fbcode_builder itself will be setup for the repo without having to do it in the PR.

X-link: facebook/folly#2268

Reviewed By: yfeldblum

Differential Revision: D60537337

Pulled By: Orvid

fbshipit-source-id: ed73693d4af93acc3b8e996a7c61d0090075949f
  • Loading branch information
mszabo-wikia authored and facebook-github-bot committed Aug 20, 2024
1 parent 9906b09 commit b2bc0ac
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 0 deletions.
23 changes: 23 additions & 0 deletions build/fbcode_builder/manifests/mcrouter
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
[manifest]
name = mcrouter

[git]
repo_url = https://github.com/facebook/mcrouter.git

[dependencies]
folly
wangle
fizz
fbthrift
mvfst
ragel

[build]
builder = cmake
subdir = .

[cmake.defines.test=on]
BUILD_TESTS=ON

[cmake.defines.test=off]
BUILD_TESTS=OFF
19 changes: 19 additions & 0 deletions build/fbcode_builder/manifests/ragel
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
[manifest]
name = ragel

[debs]
ragel

[homebrew]
ragel

[rpms]
ragel

[download]
url = https://www.colm.net/files/ragel/ragel-6.10.tar.gz
sha256 = 5f156edb65d20b856d638dd9ee2dfb43285914d9aa2b6ec779dac0270cd56c3f

[build]
builder = autoconf
subdir = ragel-6.10

0 comments on commit b2bc0ac

Please sign in to comment.