Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the wrong message while copying failed for README.md file #2249

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Corrected the wrong message while copying failed for README.md file #2249

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63094dc
Corrected the wrong message while copying failed for README.md file
tajnur007 Jun 14, 2023
6642de7
Merge branch 'main' into fix/build-error-message
tajnur007 Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions scripts/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ async function buildAll() {
console.log('Building all packages...\n');
await Promise.all(
Object.entries(PACKAGES).map(([target, config]) =>
buildPackage(target, config)
)
buildPackage(target, config),
),
);
}

Expand All @@ -85,11 +85,11 @@ async function buildPackage(target, config) {
buildRollup(
`recoil (${buildType})`,
createInputOption(buildType, target, config.inputFile),
packageTypes.map((type) =>
createOutputOption(type, target, config.umdName)
)
)
)
packageTypes.map(type =>
createOutputOption(type, target, config.umdName),
),
),
),
);

console.log('Copying files...');
Expand All @@ -104,7 +104,9 @@ async function buildPackage(target, config) {
`${projectRootDir}/README${target === 'recoil' ? '' : '-' + target}.md`,
`${BUILD_TARGET}/${target}/README.md`,
fs.constants.COPYFILE_FICLONE,
createErrorHandler(`Failed to copy README-${target}.md`),
tajnur007 marked this conversation as resolved.
Show resolved Hide resolved
createErrorHandler(
`Failed to copy README${target === 'recoil' ? '' : '-' + target}.md`,
),
);
fs.copyFile(
`${projectRootDir}/CHANGELOG-${target}.md`,
Expand Down Expand Up @@ -150,7 +152,7 @@ async function buildRollup(name, inputOptions, outputOptionsList) {
const bundle = await rollup(inputOptions);

await Promise.all(
outputOptionsList.map((outputOptions) => bundle.write(outputOptions))
outputOptionsList.map(outputOptions => bundle.write(outputOptions)),
);
} catch (error) {
createErrorHandler(`Build for package ${name} failed!`)(error);
Expand Down