Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Properly maintain type index when field is found in base type #37

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

elliekorn
Copy link
Contributor

Issue Description

We got an exception when writing a selector where a field was found in the base type of a static prefix.

Change Description

Properly maintain the type index to be the base type as appropriate.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 5, 2023
@elliekorn elliekorn merged commit bb23897 into main Aug 5, 2023
3 checks passed
@elliekorn elliekorn deleted the ellieko/selectorbasefield branch August 14, 2023 13:34
@elliekorn elliekorn restored the ellieko/selectorbasefield branch August 14, 2023 13:44
@elliekorn elliekorn deleted the ellieko/selectorbasefield branch August 14, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants