Skip to content
This repository has been archived by the owner on Aug 22, 2024. It is now read-only.

Propagate tags across references #1150

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Propagate tags across references #1150

merged 1 commit into from
Apr 3, 2022

Conversation

hermanventer
Copy link
Contributor

Description

Tags that flow to sub components also need to propagate to components that are referenced.

Relates to #1148

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

./validate.sh

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 2, 2022
@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #1150 (43029e0) into main (4fe7492) will decrease coverage by 0%.
The diff coverage is 60%.

@@          Coverage Diff          @@
##            main   #1150   +/-   ##
=====================================
- Coverage     77%     77%   -1%     
=====================================
  Files         23      23           
  Lines      16086   16173   +87     
=====================================
+ Hits       12499   12534   +35     
- Misses      3587    3639   +52     
Impacted Files Coverage Δ
checker/src/constant_domain.rs 58% <ø> (+<1%) ⬆️
checker/src/expression.rs 63% <7%> (-7%) ⬇️
checker/src/crate_visitor.rs 74% <54%> (+<1%) ⬆️
checker/src/block_visitor.rs 81% <63%> (+2%) ⬆️
checker/src/options.rs 78% <74%> (+<1%) ⬆️
checker/src/call_visitor.rs 81% <75%> (+<1%) ⬆️
checker/src/body_visitor.rs 88% <85%> (-1%) ⬇️
checker/src/type_visitor.rs 75% <87%> (+<1%) ⬆️
checker/src/abstract_value.rs 77% <91%> (-1%) ⬇️
checker/src/path.rs 86% <94%> (+<1%) ⬆️
... and 12 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@hermanventer hermanventer merged commit 053fc63 into main Apr 3, 2022
@hermanventer hermanventer deleted the tag_propagation branch April 3, 2022 00:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants