Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

fix bug of NaN left style #36

Closed
wants to merge 2 commits into from
Closed

Conversation

enbochen
Copy link

@enbochen enbochen commented May 14, 2019

This PR solves the bug after upgrading to React Native 0.58.0

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

@sharplet sharplet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the typo, this fixed the issue I was seeing after upgrading to React Native 0.58.0 where Navigator transitions were completely broken. Thanks!

@sharplet
Copy link

FWIW, these transitions still appear to work on 0.59.0, but not on the latest version, 0.59.8 (instead of an animation, the new screen just pops in).

@SpencerLynn
Copy link

This likely will fix #37

This fix is probably good, but should the styles also be fixed to not directly lead to this issue?

@enbochen enbochen closed this Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants