Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Tidy up and bug fixes #185

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

aanno
Copy link

@aanno aanno commented Mar 21, 2020

Well, as I tried this, I stepped upon a few problems:

  1. Missing documentation, hence I updated the readme.
  2. A few missing @OverRide and @FunctionalInterface.
  3. Public attributes in NGContext, hence I added getter (the setter were already there).
  4. Problems with the Classloader stuff on Java 8 11, hence it fixed that.
  5. mvn version not set to a SNAPSHOT
  6. A few missing flush().
  7. ng-version command not working in development setup.
  8. Some errors (like ClassNotFound) not propagated to client.

I decided to fix all that.

@facebook-github-bot
Copy link

Hi @aanno!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@v-jizhang
Copy link

@aanno This PR should split into multiple ones. Could you do it? Thanks.

@aanno
Copy link
Author

aanno commented Apr 30, 2020

Ok, first round:

After these 3 are accepted, I will work on the rest.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants