Skip to content
This repository has been archived by the owner on Jun 12, 2018. It is now read-only.

Use requests library instead of manual post/multipart code #39

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

psineur
Copy link
Contributor

@psineur psineur commented May 18, 2015

Summary:

First commit removes automatic auth, since I wasn't able to make it work and can't test it, looks like others have this problem as well ( #25 )
Then just small cleanup for unused imports and main change to use requests

Test Plan:

python setup.py test
and make sure authenticate() and shell mode are still working

@bgolub @mduppes @adamgross42
I guess we can use Pull Requests like this for Diff Review

Stepan Generalov added 3 commits May 15, 2015 21:06
I couldn't get this working on my machine, thus I
will be unable to test it after refactor.

Current solution would be to use long lived access
tokens obtained through Graph Explorer or 
otherwise manually.

Discuss in #25
@lsoltero
Copy link

lsoltero commented Jun 5, 2015

automatic_authentication is working for me. Happy to work with you to get this working. I think the trick is that a valid URL has to be set for the call back. It doesn't matter what the call back url is. we are using our company home page. Once setup the owner of the app can use his FB login credentials to post to /me/feeds /me/photos without issue.

@psineur
Copy link
Contributor Author

psineur commented Jun 6, 2015

Hey! This is really good to hear.

Can you create a test user & make it work for this user & post it here?
Or you can shoot me an email with credentials I can try to use.

My problem when I try to use my account ( just tried) is that throw is happening here:

421     oauth = parse_qs(auth_url.query)
422     if "state" not in oauth:

--> 423 raise AutomaticLoginError

looks like redirect doesn't happen yet but logic, that needs 'state' tries to kick in.

Can you provide details how exactly you managed auto auth to work? + your python, os versions?
Thanks!

@ghost ghost added the CLA Signed label Jul 12, 2016
@facebook-github-bot
Copy link

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired.

Before we can review or merge your code, we need you to email [email protected] with your details so we can update your status.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants