Skip to content

Commit 163903a

Browse files
David Tolnayfacebook-github-bot
David Tolnay
authored andcommitted
Update fbcode and xplat Rust toolchain
Summary: Release notes: https://blog.rust-lang.org/2024/06/13/Rust-1.79.0.html Stabilized features: - `absolute_path` - `associated_type_bounds` - `inline_const` - `pointer_is_aligned` - `slice_ptr_len` This release raises a new warning when a trait impl contains a signature that is more refined than the corresponding signature in the trait, impacting `buck2_query`. ```lang=text warning: impl trait in impl method signature does not match trait method signature --> fbcode/buck2/app/buck2_query/src/query/environment/tests.rs:73:30 | 73 | fn deps<'a>(&'a self) -> Box<dyn Iterator<Item = &'a Self::Key> + Send + 'a> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ::: fbcode/buck2/app/buck2_query/src/query/environment.rs:98:30 | 98 | fn deps<'a>(&'a self) -> impl Iterator<Item = &'a Self::Key> + Send + 'a; | ----------------------------------------------- return type from trait method defined here | = note: add `#[allow(refining_impl_trait)]` if it is intended for this to be part of the public API of this crate = note: we are soliciting feedback, see issue #121718 <rust-lang/rust#121718> for more information = note: `#[warn(refining_impl_trait_internal)]` on by default help: replace the return type so that it matches the trait | 73 | fn deps<'a>(&'a self) -> impl Iterator<Item = &'a <Self as node::LabeledNode>::Key> + std::marker::Send + 'a { | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` It also contains changes to the `dead_code` lint, which are addressed in {D59622902} and {D59623034}. Reviewed By: zertosh Differential Revision: D58982552 fbshipit-source-id: a17eaf91d07234209fddf5cbdebce4424dda57ae
1 parent e66022e commit 163903a

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

gazebo/gazebo/src/ext/str.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ use std::str::pattern::*;
1313
/// Extension traits on [`str`].
1414
///
1515
/// Set the configuration option `str_pattern_extensions` to enable the associated methods.
16-
/// The setting `str_pattern_extensions` requires the unstable features
17-
/// `pattern` and `associated_type_bounds`, so only works with Rust nightly.
16+
/// The setting `str_pattern_extensions` requires the unstable feature `pattern`,
17+
/// so only works with Rust nightly.
1818
pub trait StrExt {
1919
/// Like `split`, but only separates off the first element. For example:
2020
///

gazebo/gazebo/src/lib.rs

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
*/
99

1010
#![cfg_attr(feature = "str_pattern_extensions", feature(pattern))]
11-
#![cfg_attr(feature = "str_pattern_extensions", feature(associated_type_bounds))]
1211

1312
//! A collection of well-tested primitives that have been useful. Most modules stand alone.
1413

0 commit comments

Comments
 (0)