Skip to content

Commit e66022e

Browse files
stepanchegfacebook-github-bot
authored andcommitted
Document StarlarkTypeRepr for & is generated incorrectly
Summary: `Self` not the same `Self` when the implementation is for `&`. Reviewed By: JakobDegen Differential Revision: D59603850 fbshipit-source-id: 68ccc0756b808a6ddd33b20edff3d3bc5d9124ae
1 parent ce7a285 commit e66022e

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

starlark_derive/src/starlark_value.rs

+2
Original file line numberDiff line numberDiff line change
@@ -139,6 +139,8 @@ impl ImplStarlarkValue {
139139

140140
let lt = &self.lifetime_param;
141141
let params = &self.input.generics.params;
142+
// TODO(nga): where clause is incorrect:
143+
// if there's something `Self: Xxx` constraint, it should be `*Self: Xxx`.
142144
let where_clause = &self.input.generics.where_clause;
143145
let self_ty = &self.input.self_ty;
144146
Ok(quote_spanned! {

0 commit comments

Comments
 (0)