[Codegen] Fix generated EventEmitter code for nested objects in arrays.

[tvanlaerhoven]

Summary:

This PR fixes the code for generating EventEmitter C++ code in case nested objects in arrays are used.

export interface NativeProps extends ViewProps {
  onEvent: DirectEventHandler<
    Readonly<{
      payloadArray: Readonly<
        {
          obj: Readonly<{ str: string }>
        }[]
      >
    }>
  >;
}

export default codegenNativeComponent<NativeProps>('SomeComponent');

In this case the generated EventEmitters.cpp code would contain:

obj.setProperty(runtime, "str", payloadArrayValue,obj.str);

while

obj.setProperty(runtime, "str", payloadArrayValue.obj.str);

is expected.

Changelog:

[GENERAL] [FIXED] - Support nested objects in arrays

Test Plan:

Tested with the reproduction case above to verify correct output.

[facebook-github-bot]

Hi @tvanlaerhoven!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[elicwhite]

It seems like we don't have a test fixture that exercises this case. Can you add one/modify one that generates this issue?

[tvanlaerhoven]

It seems like we don't have a test fixture that exercises this case. Can you add one/modify one that generates this issue?

@elicwhite OK sure!

[facebook-github-bot]

@elicwhite has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.