Clear out CreateReactInstanceTaskRef early when destroying #46544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62872625 |
|
This pull request was exported from Phabricator. Differential Revision: D62872625 |
javache
force-pushed
the
export-D62872625
branch
from
b85424e
to
22e5098
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 18, 2024
…46544) Summary: Pull Request resolved: facebook#46544 Experiments with `completeReactInstanceCreationOnBgThreadOnAndroid` have shown a native crash in this code path, but it also existed previously. I believe this is due to the ordering of ReactInstance teardown: we first destroy the ReactInstance, and only then destroy the reference to it in mCreateReactInstanceTaskRef. When using the immediate executor and completeReactInstanceCreationOnBgThreadOnAndroid, we read the react instance from the task, which may no longer be valid at this point. Resetting the task at the earliest point should mitigate the issue. Changelog: [Internal] Reviewed By: markv Differential Revision: D62872625
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 18, 2024
…46544) Summary: Pull Request resolved: facebook#46544 Experiments with `completeReactInstanceCreationOnBgThreadOnAndroid` have shown a native crash in this code path, but it also existed previously. I believe this is due to the ordering of ReactInstance teardown: we first destroy the ReactInstance, and only then destroy the reference to it in mCreateReactInstanceTaskRef. When using the immediate executor and completeReactInstanceCreationOnBgThreadOnAndroid, we read the react instance from the task, which may no longer be valid at this point. Resetting the task at the earliest point should mitigate the issue. Changelog: [Internal] Differential Revision: D62872625 Reviewed By: markv
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 18, 2024
…46544) Summary: Pull Request resolved: facebook#46544 Experiments with `completeReactInstanceCreationOnBgThreadOnAndroid` have shown a native crash in this code path, but it also existed previously. I believe this is due to the ordering of ReactInstance teardown: we first destroy the ReactInstance, and only then destroy the reference to it in mCreateReactInstanceTaskRef. When using the immediate executor and completeReactInstanceCreationOnBgThreadOnAndroid, we read the react instance from the task, which may no longer be valid at this point. Resetting the task at the earliest point should mitigate the issue. Changelog: [Internal] Differential Revision: D62872625 Reviewed By: markv
…46544) Summary: Pull Request resolved: facebook#46544 Experiments with `completeReactInstanceCreationOnBgThreadOnAndroid` have shown a native crash in this code path, but it also existed previously. I believe this is due to the ordering of ReactInstance teardown: we first destroy the ReactInstance, and only then destroy the reference to it in mCreateReactInstanceTaskRef. When using the immediate executor and completeReactInstanceCreationOnBgThreadOnAndroid, we read the react instance from the task, which may no longer be valid at this point. Resetting the task at the earliest point should mitigate the issue. Changelog: [Internal] Reviewed By: markv Differential Revision: D62872625
javache
added a commit
to javache/react-native
that referenced
this pull request
Sep 19, 2024
…46544) Summary: Pull Request resolved: facebook#46544 Experiments with `completeReactInstanceCreationOnBgThreadOnAndroid` have shown a native crash in this code path, but it also existed previously. I believe this is due to the ordering of ReactInstance teardown: we first destroy the ReactInstance, and only then destroy the reference to it in mCreateReactInstanceTaskRef. When using the immediate executor and completeReactInstanceCreationOnBgThreadOnAndroid, we read the react instance from the task, which may no longer be valid at this point. Resetting the task at the earliest point should mitigate the issue. Changelog: [Internal] Differential Revision: D62872625 Reviewed By: markv
|
This pull request was exported from Phabricator. Differential Revision: D62872625 |
javache
force-pushed
the
export-D62872625
branch
from
22e5098
to
c2f119b
Compare
|
This pull request has been merged in d8aa664. |
|
This pull request was successfully merged by @javache in d8aa664 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Experiments with
completeReactInstanceCreationOnBgThreadOnAndroidhave shown a native crash in this code path, but it also existed previously.I believe this is due to the ordering of ReactInstance teardown: we first destroy the ReactInstance, and only then destroy the reference to it in mCreateReactInstanceTaskRef. When using the immediate executor and completeReactInstanceCreationOnBgThreadOnAndroid, we read the react instance from the task, which may no longer be valid at this point. Resetting the task at the earliest point should mitigate the issue.
Changelog: [Internal]
Differential Revision: D62872625