refactor: hide console and memory panels / views for profiling builds #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For profiling builds, we should be showing only what we explicitly support at the moment: Welcome panel (basically, no-op) and Performance panel.
We should not be showing Memory panel, because it requires debugger support enabled in Hermes and Console, because we currently print a warning message that JavaScript engine was compiled with no debugger support.
I believe we should roll out features (panels) for profiling builds gradually and only once they are properly tested and their support is explicitly stated.
We will also open the drawer view from Welcome panel only for development builds, because it has a Console view. If we just remove the Console view from it, then it will be just an empty drawer opened every time user navigates to Welcome panel.
Test plan
Upstreaming plan
devtools-frontend
repo. I've reviewed the contribution guide.