Skip to content

Sync fork with chromium/7103 #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4,071 commits into
base: main
Choose a base branch
from
Draft

Sync fork with chromium/7103 #161

wants to merge 4,071 commits into from
+2,790,701 −1,136,112

Conversation

huntie
Copy link
Member

@huntie huntie commented May 9, 2025 •
edited
Loading

Summary

Syncs the react-native-devtools-frontend fork with the upstream chromium/7103 branch (most recent stable from https://chromiumdash.appspot.com/branches).

There were a total of ~52 conflicts, resolved as below:

File conflicts

  • .gitignore — Merge changes
  • README.md — Keep ours
  • CONTRIBUTING.md — Both added, keep ours
  • config/gni/devtools_grd_files.gni — Merge changes
  • front_end/BUILD.gn — Merge changes
  • front_end/core/root/Runtime.ts — Merge changes
  • front_end/core/sdk/Connections.ts — Merge changes
  • front_end/core/sdk/PageResourceLoader.ts — Merge changes
    • Use upstream renamed enum keys.
  • front_end/core/sdk/sdk-meta.ts — Merge changes
  • front_end/core/sdk/sdk.ts — Keep both
  • front_end/entrypoints/inspector_main/BUILD.gn — Keep both
  • front_end/entrypoints/main/BUILD.gn — Keep both
  • front_end/entrypoints/main/MainImpl.ts — merge
  • front_end/entrypoints/shell/BUILD.gn — Keep both
  • front_end/models/source_map_scopes/NamesResolver.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/models/source_map_scopes/NamesResolver.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/models/trace/handlers/RendererHandler.ts — Merge
  • front_end/models/trace/handlers/WarningsHandler.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/models/trace/helpers/SyntheticEvents.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/models/trace/insights/DocumentLatency.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/models/trace/insights/InteractionToNextPaint.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/models/trace/lantern/core/NetworkAnalyzer.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/panels/console/consoleView.css — Keep both CSS additions
  • front_end/panels/console/ErrorStackParser.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/panels/network/network-meta.ts — Keep ours
  • front_end/panels/network/NetworkLogView.ts — Keep our customisations
  • front_end/panels/network/NetworkPanel.ts — Keep our customisations
  • front_end/panels/profiler/HeapSnapshotView.ts — Merge
    • Preserve our rnPerfMetrics calls.
  • front_end/panels/sources/SourcesView.ts — Use upstream
    • Conditionally hidden UI no longer present.
  • front_end/panels/sources/UISourceCodeFrame.ts — Keep our customisations
  • front_end/panels/timeline/EntriesFilter.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/panels/timeline/Initiators.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/panels/timeline/ModificationsManager.test.ts — Use upstream, then reapply Performance: hide more unsupported features #150
  • front_end/panels/timeline/TimelineFlameChartDataProvider.ts — Keep our customisations
  • front_end/panels/timeline/TimelinePanel.ts — Merge
    • Preserve our disabled Performance features.
  • front_end/panels/timeline/TimelineLandingPage.ts — Deleted upstream
  • front_end/panels/timeline/TimingsTrackAppender.ts — Use upstream
  • front_end/testing/EnvironmentHelpers.ts — Keep both (experiment keys)
  • front_end/third_party/additional_readme_paths.json — Keep both (manifest file)
  • front_end/ui/components/input/checkbox.css — Use upstream
  • front_end/ui/legacy/ActionRegistration.ts — Keep our extra icons
  • front_end/ui/legacy/BUILD.gn — Merge
  • front_end/ui/legacy/components/utils/TargetDetachedDialog.ts — Merge changes
  • front_end/ui/legacy/inspectorCommon.css — Use upstream (not modified by us)
  • front_end/ui/legacy/remoteDebuggingTerminatedScreen.css — Keep ours
  • front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts — Merged
    • Keep our dialog design, lit-html -> lit.
  • front_end/ui/legacy/theme_support/ThemeSupport.ts — Merge
    • Preserve our baseline-greyscale override.
  • third_party/node/node.py — Use upstream (includes our fix)

Test plan

To dos

[Incoming]

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

yisibl and others added 30 commits March 20, 2025 05:03
@yisibl
Mark border-inline/block as a color property
9d3c991 
- Fixes an issue that previously prevented ColorSwatch from being displayed
- Make these properties show the Color keyword when Autocomplete.

Added the following properties:

 - 'border-inline',
 - 'border-inline-color',
 - 'border-block',
 - 'border-block-color',

and complementary SVG-related color properties:

 - 'flood-color',
 - 'lighting-color',
 - 'stop-color'

pfaffe@ has previously added some other border properties, see:

https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5667297

Bug: 389048232
Change-Id: Ibef893f7154458d9552dfaf6180ab6c9ee93d452
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6371612
Reviewed-by: Philip Pfaffe <[email protected]>
Commit-Queue: 一丝 <[email protected]>
@masnoble
Reland "Have InspectorView remove the Infobar instead of CookieContro…
7411149 
…lsView"

This is a reland of commit 1ac4ec6

Original change's description:
> Have InspectorView remove the Infobar instead of CookieControlsView
>
> If CookieControlsView was responsible for listening for a
> PrimaryPageChanged event and then removing the Infobar, the infobar
> would not be removed if CookieControlsView was never created to
> listen in the first place. This is a problem because the Infobar
> might be created by the InspectorMain entrypoint which does not
> guarantee that a CookieControlsView will be created as well.
>
> By moving the listener to the InspectorView, we guarantee that the
> Infobar is removed when the user reloads the page without needing
> to open the Privacy and security panel.
>
> Bug: 400962121
> Change-Id: I612c4899e218e094fd31a3eda154ec69c20e8035
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6346989
> Reviewed-by: Kim-Anh Tran <[email protected]>
> Reviewed-by: Danil Somsikov <[email protected]>
> Commit-Queue: Joshua Thomas <[email protected]>

Bug: 400962121
Change-Id: Id4b4c5a1e46e84877642978c3763af784ff751b6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367775
Reviewed-by: Danil Somsikov <[email protected]>
Reviewed-by: Kim-Anh Tran <[email protected]>
Commit-Queue: Joshua Thomas <[email protected]>
Update Chrome (for Testing) PIN
10cf604 
Chromium pin updated to 136.0.7079.0

Roll created at https://cr-buildbucket.appspot.com/build/8719879389676520017

Bug: none
Change-Id: Icf799ed3d6f0359472a841a0190dd08e291539c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375025
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
@ktran
[GM3Restyling] Update WebAudio key-value pair
be289f6 
Before: https://i.imgur.com/aVWAr49.png
After: https://i.imgur.com/p3UWBUC.png
Bug: 325443308
Change-Id: I603e8271493508855fabe33a45e08a36de35fbea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375503
Reviewed-by: Kateryna Prokopenko <[email protected]>
Commit-Queue: Kim-Anh Tran <[email protected]>
@Lightning00Blade
[AI Assistance] Ignore AI Assistance selectors
969d667 
Fixed: 405049967
Change-Id: I4c254f2787a367d4dba8d96ae07c462a98f6f622
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375523
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
@danilsomsikov
Temporarily add logging to loadLegacyModule to investigate test tim…
77ab97d 
…eouts on bots

Bug: 345556266
Change-Id: I8b1f95389bfb22d388747f6251a7959b44d1e294
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375263
Auto-Submit: Danil Somsikov <[email protected]>
Commit-Queue: Philip Pfaffe <[email protected]>
Reviewed-by: Philip Pfaffe <[email protected]>
@ergunsh
[PatchWidget] Update known context values for patch widget and combin…
93d0429 
…ed diff view

Bug: none
Change-Id: I4aa03ebf9a89794d4ad36b029233ab44be59dadf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376067
Commit-Queue: Ergün Erdoğmuş <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>
Commit-Queue: Nikolay Vitkov <[email protected]>
Auto-Submit: Ergün Erdoğmuş <[email protected]>
@pfaffe
Prevent default in tooltip hotkeys
86849c0 
Fixed: 404535134
Change-Id: Id1930b7023938154a1b46348b6c2170eab89d66c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6368838
Reviewed-by: Eric Leese <[email protected]>
Commit-Queue: Eric Leese <[email protected]>
Auto-Submit: Philip Pfaffe <[email protected]>
[RPP] Hover/click on 3P table and 3P grouped AggregatedTimelineTreeView
3e6c7f0 
includes `SyntheticNetworkRequests`

Because tree views only consider events on the Main thread, we need to
make an exception for when considering 3P (as this includes network requests). So on hover/click we should include network requests for
completion using the entity mapper.

https://screencast.googleplex.com/cast/NjIyNjk4NzE1OTkxMjQ0OHxjYzJhYjc2MS05Nw

Bug: 394651390
Change-Id: I5d127a6dce58bd54a7fbbfeabd4401753b8f3bf8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6374483
Commit-Queue: Adriana Ixba <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
@paulirish
RPP: More explanatory comments for TimelineTreeView
ebe7c75 
Bug: 394651390
Change-Id: I05d15ba3f0e2ff2e6a7b3fb9414f4cc5bba27557
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6373790
Commit-Queue: Adriana Ixba <[email protected]>
Auto-Submit: Paul Irish <[email protected]>
Reviewed-by: Adriana Ixba <[email protected]>
@bmeurer
[docs] Add more documentation for npm run build.
ec23749 
Specifically document the Linux specific limits for `inotify` which
one can easily run into when combining `npm run build -- --watch`
and VS code.

Bug: 404192426
Change-Id: Idf301cb2e773325b2d299e61e879f85541551aa4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376063
Reviewed-by: Nikolay Vitkov <[email protected]>
Auto-Submit: Benedikt Meurer <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
@ktran
Fix missing styles for interest group empty state
166922f 
After dropping the `adoptedStyleSheets` the styles went missing for
the interest group tab's empty state. This CL moves the rendering
of the empty state into the main `render` method, under which we also
include the correct styles.

Before: https://i.imgur.com/N3xS6DM.png
After: https://i.imgur.com/3W26pvn.png
Bug: none
Change-Id: If8eed04ec054e199d08053337cd3e6b2d3112c5e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376103
Commit-Queue: Benedikt Meurer <[email protected]>
Auto-Submit: Kim-Anh Tran <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
[RPP] Improve performance of singleton overlays
2035fca 
Every call to `add` a new overlay would iterate over all existing
overlays to manage singletons specially. For an extreme case of ~70k
overlays, this resulted in ~22s of extra processing time on my M1 Mac.

This CL reduces it down to 5ms by simply storing singleton overlays in
a map for constant time lookup.

Example trace w/ many overlays on 3p insight:  https://trace.cafe/t/V7sS5bz7F0

Bug: 40278532
Change-Id: Ia8b76892e4f22f1a60215fffcc999fb4862121a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376737
Commit-Queue: Connor Clark <[email protected]>
Auto-Submit: Connor Clark <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Update Chrome (for Testing) PIN
95461d3 
Chromium pin updated to 136.0.7080.0

Roll created at https://cr-buildbucket.appspot.com/build/8719822769335182177

Bug: none
Change-Id: Ie9c412cdf016ba0316c50e4e2fd9e4a1f2276bc3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6377848
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
@jackfranklin
AI: manually strip 5 backticks from LLM response in Insights agent
40ec258 
See bug for context, we sometimes see the LLM wrap its response in 5
backticks for no apparent reason. We're going to sync with the Aida
folks to see if we can understand why or fix this on their side, but for
now a fix is also to strip the 5 backticks if they are found in the
response.

Bug: 405054694
Change-Id: Ieb7499af142f7f7cba9ffea999729f49e1fbe536
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375525
Auto-Submit: Jack Franklin <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>
@ergunsh
[CombinedDiffView] Render workspace relative URL or full display name
ed9d0d5 
Fixed: 405095525
Change-Id: I547dc6bb01c06a77147c2967fae1230dcb42a2eb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6376066
Reviewed-by: Simon Zünd <[email protected]>
Auto-Submit: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
@jackfranklin
RPP: add rich tooltip to annotation label generation
df4d71f 
Fixed: 405061222
Change-Id: I3a7bc85e40512e3f9de244a0258377b9e3da2077
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6375726
Commit-Queue: Jack Franklin <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
@jackfranklin
Try to deflake RPP landing page test
ab91490 
This has flaked a few times. Trying to see if this retry function will
improve its stability, as we have quite a few rAFs to try to make this
test work.

Bug: 405356930
No-Presubmit: True
No-Tree-Checks: True
No-Try: True
Change-Id: Ib9864aef67413ef1d3fa36d99359e8756b6626cb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381858
Reviewed-by: Andres Olivares <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Roll browser-protocol
ec072de 
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8719788792218476385

[email protected]

Bug: none
Change-Id: Ic9b4442aecfc18ffaf55966d2737fe4ff870395b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381836
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Jack Franklin <[email protected]>
@jackfranklin
RPP: add auto-annotation label generation
34aaed6 
Fixed: 405061899
Change-Id: Idf06927221664dfa45a1ba3215fb5f2a6ad99084
Also-by: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381853
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
@Lightning00Blade
Fix dialog width for undocked DevTools
a0151c2 
Bug: none
Change-Id: I819e3671f84eade93c5e3014a08b8b208cf4e5a6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382413
Commit-Queue: Nikolay Vitkov <[email protected]>
Auto-Submit: Nikolay Vitkov <[email protected]>
Commit-Queue: Kateryna Prokopenko <[email protected]>
Reviewed-by: Kateryna Prokopenko <[email protected]>
@danilsomsikov
Also test protocol monitor autocomplete
0eebfab 
Bug: none
Change-Id: I88792c9561ab7950063335c9b949a7d10e6a5ae9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6330113
Reviewed-by: Nancy Li <[email protected]>
Commit-Queue: Nancy Li <[email protected]>
Auto-Submit: Danil Somsikov <[email protected]>
@jackfranklin
RPP: hide auto-annotations behind feature flag
4d79dad 
Bug: none
Change-Id: I44314f07516a6444b18bfc877efb1e0c0488fac8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383675
Reviewed-by: Andres Olivares <[email protected]>
Auto-Submit: Jack Franklin <[email protected]>
Commit-Queue: Andres Olivares <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Update Chrome (for Testing) PIN
f0dda7c 
Chromium pin updated to 136.0.7082.2

Roll created at https://cr-buildbucket.appspot.com/build/8719732170690310641

Bug: none
Change-Id: I20016dec784528efaf22d90184e369d3bd1d1c7b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383277
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Update Chrome (for Testing) PIN
1aa930d 
Chromium pin updated to 136.0.7083.0

Roll created at https://cr-buildbucket.appspot.com/build/8719698197868596177

Bug: none
Change-Id: I8c8977764f4698385a6df7b8a76034681273a06f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383824
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Update Chrome (for Testing) PIN
7633ebb 
Chromium pin updated to 136.0.7084.0

Roll created at https://cr-buildbucket.appspot.com/build/8719641573921810753

Bug: none
Change-Id: Ia627446634cb4cd1d0e27aed2c8b1d5604f621dc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381661
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
[documentation] adjust the Tshirt sizing table based on feedback from…
f34da11 
… SWEs

Change-Id: If356c1c17c13741ea8571a2ee47936aaa50e2bd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367394
Reviewed-by: Benedikt Meurer <[email protected]>
Commit-Queue: Meysam Sarabadani <[email protected]>
Reviewed-by: Danil Somsikov <[email protected]>
@pfaffe
[css value tracing] No initial focus when showing trace tooltip
16ee2a9 
Fixed: 404535428
Change-Id: Ib6059ea7d278a172dc1e0880582a1a94bd255859
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6372801
Reviewed-by: Eric Leese <[email protected]>
Commit-Queue: Philip Pfaffe <[email protected]>
Update Chrome (for Testing) PIN
6db9776 
Chromium pin updated to 136.0.7086.0

Roll created at https://cr-buildbucket.appspot.com/build/8719550977847411953

Bug: none
Change-Id: I5e61d37fff280905844083c08c8306cb3a61876e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383222
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Update DevTools DEPS (trusted)
fe7dc48 
Rolling third_party/siso: git_revision:3a38836e06344016dce6092148a07a114807f9f0..git_revision:ae99e5f46d1fbc718ad9c28bb82c16883d7de99b

Roll created at https://cr-buildbucket.appspot.com/build/8719550977847411953

Bug: none
Change-Id: I91f43bb20ce1371651cf60f1f3cecd1ebb9e7102
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6383221
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
AlinaVarkki and others added 28 commits March 31, 2025 08:53
@AlinaVarkki
[RPP][AI] Add a condition to the Auto Labelling Agent prompt
0e2f967 
It  sometimes returns multi-line responses, let's try to prevent it.

Bug:None
Change-Id: I2d1044c3f230cb31377441b9bb9a063aa179e5ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6414390
Commit-Queue: Alina Varkki <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Auto-Submit: Alina Varkki <[email protected]>
Reviewed-by: Jack Franklin <[email protected]>
What's new in DevTools, Chrome 136
9491d58 
Bug:407504567
Change-Id: I620923eed0b9df358e7c70a4fa27d6b0527e9008
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415614
Reviewed-by: Danil Somsikov <[email protected]>
Commit-Queue: Sofia Emelianova <[email protected]>
@danilsomsikov
[eslint] Fix strict tsc issues in the no-imperative-dom-api
305ec9b 
Bug: 407085691
Change-Id: If07beab48274b5491e78576556434db3b3670495
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6414778
Commit-Queue: Danil Somsikov <[email protected]>
Reviewed-by: Nikolay Vitkov <[email protected]>
[RPP] Add Legacy JavaScript insight component
cf5c715 
- Shown by default (not in experimental)
- Adds `scriptRef` helper for rendering a script
- Sorts results by estimated savings in the model
- Filter out results less than 5kb in the model

Fixed: 394373852
Change-Id: I7558f9dba01238b1af80a6d8d500b900bd03b964
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410451
Auto-Submit: Connor Clark <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Commit-Queue: Connor Clark <[email protected]>
[RPP] Fix some bugs related to using the wrong time units
95644fe 
- The insights sorting criteria incorrectly used wrong time units for
  field data
- #getFilmStripFrame incorrectly compared times in different units

These bugs were discovered by a custom eslint rule that has not yet
landed[1].

[1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395588

Bug: 406518012
Change-Id: I7a19181bf1362f200bb9038dca6fff06b16555a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6417905
Auto-Submit: Connor Clark <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Commit-Queue: Connor Clark <[email protected]>
[Lighthouse] Fix dropdown menu cutting off insights toggle
33b5798 
Bug: none
Change-Id: I40fd354d1973656d654f45841b2949d2eab577c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6418602
Reviewed-by: Paul Irish <[email protected]>
Commit-Queue: Connor Clark <[email protected]>
Auto-Submit: Connor Clark <[email protected]>
@pfaffe
[devtools-tooltip] set overflow to auto
99d11db 
This avoids overflowing in tooltips that are wider than the max width

Bug: 407700484
Fixed: 407922462
Change-Id: I33125ff7ffc8fdc4292ec1ae7efa5b7577e8911e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6421824
Reviewed-by: Kim-Anh Tran <[email protected]>
Commit-Queue: Kim-Anh Tran <[email protected]>
Auto-Submit: Philip Pfaffe <[email protected]>
(cherry picked from commit c0e9085)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6429365
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Philip Pfaffe <[email protected]>
@and-oli
[RPP] check for negative entry index before processing initiator data
5485ee0 
The check for -1 value is moved early in the processing, to ensure the
data is cleared up and not prevented due to early returns.

Bug: 408140272
Fixed: 408183703
Change-Id: Icbf4f88403b0e7642e311ff810133bfa34329238
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6429725
Commit-Queue: Andres Olivares <[email protected]>
Auto-Submit: Andres Olivares <[email protected]>
Reviewed-by: Alina Varkki <[email protected]>
(cherry picked from commit 5c0078a)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6434407
Bot-Commit: Rubber Stamper <[email protected]>
@ktran
[M136] Reduce tooltip/popover paddings and adjust border radius
3182688 
Bug: 408140891
Fixed: 408933042
Change-Id: Ifcf600bbb6b40dee4dc75da7f83fd7ab48b2b1d6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6429844
Auto-Submit: Kim-Anh Tran <[email protected]>
Reviewed-by: Kateryna Prokopenko <[email protected]>
Commit-Queue: Kim-Anh Tran <[email protected]>
(cherry picked from commit 3abf776)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6434890
[M136] Reduce default tooltip paddings
6f99640 
Fix shadow and remove arrow Margin behaviour as a drive-by

Bug: 406466030
Change-Id: Iaaf6abde4f255e11d9056f89f1b8cfa448148805
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6425299
Reviewed-by: Kim-Anh Tran <[email protected]>
Commit-Queue: Kim-Anh Tran <[email protected]>
Auto-Submit: Kateryna Prokopenko <[email protected]>
(cherry picked from commit 773da36)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6437729
Commit-Queue: Kateryna Prokopenko <[email protected]>
@jackfranklin
[RPP] Fix bug that double-counts transfer size in 3p table
afb29fc 
Bug: 408275043
Fixed: 408368319
Change-Id: I966155b37e08f32f2640823f46b0c214095775f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6431348
Reviewed-by: Jack Franklin <[email protected]>
Commit-Queue: Jack Franklin <[email protected]>
Auto-Submit: Connor Clark <[email protected]>
(cherry picked from commit 59e1ee7)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6438912
Reviewed-by: Alex Rudenko <[email protected]>
@ktran
[M136] Adjust filter bar width for settings experiments
66ad26d 
Before: https://i.imgur.com/lOcJJw8.png
After: https://i.imgur.com/QYs8Ug8.png
Bug: 408940901
Fixed: 409179188
Change-Id: I8deb54cc5d2ec1724211ec372ad15323738ee67f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6434119
Commit-Queue: Kim-Anh Tran <[email protected]>
Reviewed-by: Kateryna Prokopenko <[email protected]>
(cherry picked from commit 2e5bee2)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6438996
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Kim-Anh Tran <[email protected]>
[RPP] Disable v8-source-rundown-sources event unless exp is on
9d6e5b4 
Partial revert of https://crrev.com/c/6293325

Bug: 409086863
Fixed: 410040501
Change-Id: I1b9f58ef3ee364af2c919df3162f2be1f7dcb143
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6448573
Auto-Submit: Connor Clark <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Commit-Queue: Connor Clark <[email protected]>
(cherry picked from commit 5e20990)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6455510
Commit-Queue: Paul Irish <[email protected]>
@danilsomsikov
[M136] Remove extra whitespace when editing cookie Priority or SameSite
e191c92 
Bug: 409033193
Fixed: 409199516
Change-Id: I621d7ef22c8a63305e3b41bafc2106e59c33e9a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6432956
Auto-Submit: Danil Somsikov <[email protected]>
Reviewed-by: Philip Pfaffe <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
(cherry picked from commit 31fc845)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6455745
@danilsomsikov
[M136] Emit create event when user clicks outside of the editor
eed8b20 
Bug: 408244902
Fixed: 409200069
Change-Id: I796e53b62a01219c84742373bf6e00c027f32560
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6436657
Reviewed-by: Philip Pfaffe <[email protected]>
Auto-Submit: Danil Somsikov <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
(cherry picked from commit e8b639c)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6456264
@ktran
[M136][popover] Popovers should allow text selection
c10f8d8 
Bug: 408225523, 409188467
Change-Id: I371728da766b9a12393a925b0c54508bf3392d57
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6440816
Commit-Queue: Kateryna Prokopenko <[email protected]>
Reviewed-by: Kateryna Prokopenko <[email protected]>
Auto-Submit: Kim-Anh Tran <[email protected]>
(cherry picked from commit 2816e66)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6456625
Bot-Commit: Rubber Stamper <[email protected]>
@pfaffe
Fix regression in rendering css keywords
6ba8b56 
Bug: 409325196
Fixed: 409341424
Change-Id: I1a51b5ed045b5a334a6407b693709c3cd12af67a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6439041
Reviewed-by: Benedikt Meurer <[email protected]>
Auto-Submit: Philip Pfaffe <[email protected]>
Commit-Queue: Philip Pfaffe <[email protected]>
(cherry picked from commit 93ebef8)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6456626
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
@ktran
[M136] [popover] Make popover scrollable again
0a3f7c5 
Bug: 408225523
Fixed: 409188467
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6439159
Reviewed-by: Kateryna Prokopenko <[email protected]>
Commit-Queue: Kim-Anh Tran <[email protected]>
Auto-Submit: Kim-Anh Tran <[email protected]>
(cherry picked from commit a1dabaf)
Change-Id: Ifd851a4507c2e34de36338a1b0bb538f24554ba6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6456627
Bot-Commit: Rubber Stamper <[email protected]>
@Lightning00Blade
Don't show tooltip if hover is a drag
67bf1de 
Note: This does not fix the behavior that the text of a tooltip is being selected if the anchor had an active text selection before hovering.

Change-Id: I15135dfbb040ef60af83b00ac14df38c59d522f8
Bug: 409988275
Fixed: 410486388
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6448276
Commit-Queue: Nikolay Vitkov <[email protected]>
Reviewed-by: Philip Pfaffe <[email protected]>
(cherry picked from commit e265def)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6458418
Auto-Submit: Nikolay Vitkov <[email protected]>
@wolfib
[m136] Report test durations in seconds, not ms
c4dc89b 
Bug: 408145209, 411315974
Change-Id: I25bc8902ea54c3dc994b9e00dce11351dc7221b7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6430184
Auto-Submit: Eric Leese <[email protected]>
Reviewed-by: Liviu Rau <[email protected]>
Commit-Queue: Liviu Rau <[email protected]>
Commit-Queue: Eric Leese <[email protected]>
(cherry picked from commit e4c5ad5)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468181
Bot-Commit: Rubber Stamper <[email protected]>
@wolfib
[m136] Always round test duration to milliseconds
91f0826 
Bug: 408145209
Fixed: 411315974
Change-Id: I7246d08a8ff033c081a141b49ded7070f977ddd6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6429854
Commit-Queue: Eric Leese <[email protected]>
Reviewed-by: Philip Pfaffe <[email protected]>
Reviewed-by: Liviu Rau <[email protected]>
(cherry picked from commit 9876f54)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468182
Bot-Commit: Rubber Stamper <[email protected]>
@pfaffe
[tooltips] Fix property docs tooltip setting
bebf6b6 
Bug: 409985196
Fixed: 410515701
Change-Id: Ie7d1cd7bd470faf8814689840c9436cdd64ef09f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6450702
Commit-Queue: Philip Pfaffe <[email protected]>
Auto-Submit: Philip Pfaffe <[email protected]>
Reviewed-by: Ergün Erdoğmuş <[email protected]>
Commit-Queue: Ergün Erdoğmuş <[email protected]>
(cherry picked from commit 5378490)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6461929
Bot-Commit: Rubber Stamper <[email protected]>
[Lighthouse] Prevent crash by disabling invalidationTracking event
b56477a 
Bug: 411728380
Fixed: 412378555
Change-Id: Ibf062a17e1a6ba30d53dab9d7530dcf88b141917
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6472150
Reviewed-by: Paul Irish <[email protected]>
Commit-Queue: Connor Clark <[email protected]>
Auto-Submit: Connor Clark <[email protected]>
(cherry picked from commit 4ef47f3)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6476926
Commit-Queue: Paul Irish <[email protected]>
@danilsomsikov
Consistently apply filters to viewport data grid nodes
bbe7242 
Bug: 411285104
Fixed: 411310102
Change-Id: Icf309edf064a05a650b5d45754b58dfb7485347e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6468177
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Danil Somsikov <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
Auto-Submit: Danil Somsikov <[email protected]>
(cherry picked from commit 0b33e61)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6476907
Auto-Submit: Connor Clark <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
@danilsomsikov
Limit value display in KeyValueStorageItemsView.
0489af3 
The UI was previously freezing when the user tries to render large values.

We are now truncating the value to 4096 chars.

Bug: 408976043
Fixed: 410744529
Change-Id: I75fec294ae474b6cc5871fc5c9c6e722561b122a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6455747
Commit-Queue: Benedikt Meurer <[email protected]>
Auto-Submit: Danil Somsikov <[email protected]>
Reviewed-by: Benedikt Meurer <[email protected]>
(cherry picked from commit b75904f)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6476906
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Auto-Submit: Connor Clark <[email protected]>
@hanselfmu @hanselfmu-chromium
Fix translation strings for M136.
e793e21 
Bug: 410511500
Fixed: 412033240
Change-Id: I78c45a79d7a26ca0bd838a7c25352934e8e38ae0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6454343
Reviewed-by: Simon Zünd <[email protected]>
Commit-Queue: Changhao Han <[email protected]>
(cherry picked from commit 272fb83)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6475146
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Commit-Queue: Simon Zünd <[email protected]>
Commit-Queue: Paul Irish <[email protected]>
Reviewed-by: Paul Irish <[email protected]>
Auto-Submit: Changhao Han <[email protected]>
[M136] Fix paddings and corner radii for flex, grid and shadow editors
4a53cbe 
Bug: 409771454
Change-Id: I19e9840d78ee245c1a15b5d8e65485eb227d4aa1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6459230
Reviewed-by: Kim-Anh Tran <[email protected]>
Commit-Queue: Kateryna Prokopenko <[email protected]>
Auto-Submit: Kateryna Prokopenko <[email protected]>
Commit-Queue: Kim-Anh Tran <[email protected]>
(cherry picked from commit 199588f)
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6513135
@huntie
Merge remote-tracking branch 'chromedevtools/chromium/7103' into repo…
5b74d92 
…-sync

# Conflicts:
#	.gitignore
#	CONTRIBUTING.md
#	README.md
#	config/gni/devtools_grd_files.gni
#	front_end/BUILD.gn
#	front_end/core/root/Runtime.ts
#	front_end/core/sdk/Connections.ts
#	front_end/core/sdk/PageResourceLoader.ts
#	front_end/core/sdk/sdk-meta.ts
#	front_end/core/sdk/sdk.ts
#	front_end/entrypoints/inspector_main/BUILD.gn
#	front_end/entrypoints/main/BUILD.gn
#	front_end/entrypoints/main/MainImpl.ts
#	front_end/entrypoints/shell/BUILD.gn
#	front_end/models/source_map_scopes/NamesResolver.test.ts
#	front_end/models/source_map_scopes/NamesResolver.ts
#	front_end/models/timeline_model/TimelineModelFilter.test.ts
#	front_end/models/trace/handlers/RendererHandler.ts
#	front_end/models/trace/handlers/WarningsHandler.test.ts
#	front_end/models/trace/helpers/SyntheticEvents.test.ts
#	front_end/models/trace/insights/CumulativeLayoutShift.test.ts
#	front_end/models/trace/insights/DocumentLatency.test.ts
#	front_end/models/trace/insights/InteractionToNextPaint.test.ts
#	front_end/models/trace/insights/LargestContentfulPaint.test.ts
#	front_end/models/trace/lantern/core/NetworkAnalyzer.test.ts
#	front_end/panels/console/ErrorStackParser.test.ts
#	front_end/panels/console/consoleView.css
#	front_end/panels/network/NetworkLogView.ts
#	front_end/panels/network/NetworkPanel.ts
#	front_end/panels/network/network-meta.ts
#	front_end/panels/profiler/HeapSnapshotView.ts
#	front_end/panels/sources/SourcesView.ts
#	front_end/panels/sources/UISourceCodeFrame.ts
#	front_end/panels/timeline/EntriesFilter.test.ts
#	front_end/panels/timeline/Initiators.test.ts
#	front_end/panels/timeline/ModificationsManager.test.ts
#	front_end/panels/timeline/TimelineFlameChartDataProvider.ts
#	front_end/panels/timeline/TimelineLandingPage.ts
#	front_end/panels/timeline/TimelinePanel.ts
#	front_end/panels/timeline/TimingsTrackAppender.ts
#	front_end/testing/EnvironmentHelpers.ts
#	front_end/third_party/additional_readme_paths.json
#	front_end/ui/components/input/checkbox.css
#	front_end/ui/legacy/ActionRegistration.ts
#	front_end/ui/legacy/BUILD.gn
#	front_end/ui/legacy/RemoteDebuggingTerminatedScreen.ts
#	front_end/ui/legacy/components/utils/TargetDetachedDialog.ts
#	front_end/ui/legacy/inspectorCommon.css
#	front_end/ui/legacy/remoteDebuggingTerminatedScreen.css
#	front_end/ui/legacy/theme_support/ThemeSupport.ts
#	scripts/eslint_rules/lib/check-license-header.js
#	third_party/node/node.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.