Clear read callback on EOF #550
Open
+65
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: mvfst can deliver readError after an EOF if the stream still has the read callback set. After we delete the read callback (from the ingress stream map) we need to clear the callback to prevent UAF. Differential Revision: D69469439
|
This pull request was exported from Phabricator. Differential Revision: D69469439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: mvfst can deliver readError after an EOF if the stream still has the read callback set. After we delete the read callback (from the ingress stream map) we need to clear the callback to prevent UAF.
Differential Revision: D69469439